Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with duplicated experiment name in querying #168

Open
angus-g opened this issue Mar 23, 2020 · 4 comments
Open

Deal with duplicated experiment name in querying #168

angus-g opened this issue Mar 23, 2020 · 4 comments
Labels
🥞 database Related to the structure of the database itself

Comments

@angus-g
Copy link
Collaborator

angus-g commented Mar 23, 2020

We try to limit the assumptions made in the database, so experiment names (like 01deg_jra55v13_ryf9091) aren't themselves unique — rather, the combination of experiment name and its root directory is. However, in functions like cc.querying.getvar, we only ask for the experiment name. This could lead to some unexpected behaviour, pulling files from two experiments with the same name, but a different root directory.

@AndyHoggANU
Copy link
Collaborator

Good point, sorry. Actually, that particular experiment name is unique it is just that (for a short time) there is a duplicate copy on both hh5 and ik11. So, I will delete the hh5 copy as soon as I can convince myself that the rsync went well.

@rmholmes
Copy link

rmholmes commented Mar 23, 2020

Actually, this was because I had two versions of the same folder listed on hh5, one with /g/data/hh5/ and one with /g/data3/hh5/. This should be easy to avoid...

@angus-g
Copy link
Collaborator Author

angus-g commented Mar 23, 2020

Should be easy to avoid, but I don't think it should break so horribly in these cases!

@aidanheerdegen aidanheerdegen added the 🥞 database Related to the structure of the database itself label Sep 1, 2020
@aidanheerdegen
Copy link
Collaborator

The idea of a unique experiment id could address this I think. In the case where there is match with multiple IDs the operation could error and the user warned that manual disambiguation is required. The same thing could be done if there are multiple root paths I guess.

In any case, definitely a related issue

payu-org/payu#191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥞 database Related to the structure of the database itself
Projects
None yet
Development

No branches or pull requests

4 participants