Battery improvements

[BenWinchester]

General

There are several improvements that should be made to the battery code within CLOVER. These issues and discussions are mentioned here.

Issues merged here

• 🐛 Bugs
  • Battery degradation rates

Bugs

Bugs that have been merged under the general issue of battery improvements are below

📉 Battery degradation rates

Issue: #132
Discussion: #194

Discussed in #194

^{Originally posted by BenWinchester October 20, 2022}

Describe the bug

The battery degradation rates are not behaving as expected as both the maximum and minimum capacities are degrading whereas, in reality, the minimum shouldn't degrade at any rate. This is unexpected behaviour and the minimum capacity .

To Reproduce

Steps to reproduce the behavior:
This functionality is hard baked into the code:

maximum_battery_storage = (
    battery_storage_degradation
    * electric_storage_size
    * minigrid.battery.maximum_charge  # type: ignore
    * minigrid.battery.storage_unit  # type: ignore
)
minimum_battery_storage = (
    battery_storage_degradation
    * electric_storage_size
    * minigrid.battery.minimum_charge  # type: ignore
    * minigrid.battery.storage_unit  # type: ignore
)

Expected behaviour

Here, the minimum battery storage should not be degradading

maximum_battery_storage = (
    battery_storage_degradation
    * electric_storage_size
    * minigrid.battery.maximum_charge  # type: ignore
    * minigrid.battery.storage_unit  # type: ignore
)
-minimum_battery_storage = (
-    battery_storage_degradation
-    * electric_storage_size
-    * minigrid.battery.minimum_charge  # type: ignore
-    * minigrid.battery.storage_unit  # type: ignore
-)

Screenshots

Screenshots are not applicable, code snippet has been included.

Additional Information

Desktop

(please complete the following information)

• OS: 🐧 but applicable to 🍎 and 🏁
• Installation setup: git clone
• Version: v5.0.5
• Branch, if relevant: diesel-dev but found in master

Modifications

None applicable.