Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire BlackMarble? #77

Open
chahank opened this issue May 15, 2023 · 6 comments
Open

Retire BlackMarble? #77

chahank opened this issue May 15, 2023 · 6 comments

Comments

@chahank
Copy link
Member

chahank commented May 15, 2023

As far as I understand, the functionalities from the module BlackMarble are all also implemented in the LitPop module. Should we then consider retiring BlackMarble?

@peanutfun
Copy link
Member

Why was I assigned? I have no idea 😅 From a quick glance, BlackMarble uses functions from climada.entity.exposures.litpop. So it seems like it adds some functionality on top?

@aleeciu @sameberenz @gabrielaznar @tovogt You are involved in the history of the source files. We would highly appreciate some insight into what BlackMarble does that is currently not provided by LitPop.

@peanutfun peanutfun removed their assignment May 16, 2023
@aleeciu
Copy link
Collaborator

aleeciu commented May 16, 2023

As far as I understand, BlackMarble is a LitPop exposure which makes no use of pop data. If so, I am in favour of removing BlackMarble and:

  • adding a line in the LitPop docstring on how one can still generate BlackMarble
    OR
  • keeping a simple function called BlackMarble which simply calls LitPop with the right params

@chahank
Copy link
Member Author

chahank commented May 16, 2023

Why was I assigned? I have no idea 😅

My logic was that you are the last that has had a detailed look at the LitPop code, so you might now best :D

@gabrielaznar
Copy link
Member

That's right; BlackMarble only uses nightlight and not population. You can therefore get BlackMarble from LitPop as well. There were though some small differences using the nightlights in BlackMarble and LitPop (e.g. coupling the images) but they shouldn't change much the results.

I think the only big difference now is that BlackMarble supports using the NOAA nightlights which are available yearly from 1992 till 2013. NASA nightlights are only available for 2012 and 2016 but at higher resolution than NOAAs (~500m vs ~1km).

@aleeciu
Copy link
Collaborator

aleeciu commented May 16, 2023

that's a good point - I guess having access to past data might be handy in some cases

@peanutfun
Copy link
Member

The utility functions for downloading NASA and NOAA nightlights, which are used by BlackMarble, are actually part of the Core. However, they are never used there. They seem to have a strong overlap with the other functions implemented in Core, see nightlight.py. If we consolidate them, we can add the functionality of downloading NOAA files to the Core nightlight implementation. This would then allow to remove BlackMarble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants