-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vector not projected (at robinson at least) #357
Comments
@scottwittenburg @aashish24 at your convenience pull the commit from the good branch |
@scottwittenburg we should check if this is still true. |
Will do. I suspect it is still true, since I haven't addressed it myself yet. Thanks for the reminder. |
@doutriaux1 @scottwittenburg I'll start looking at this. |
@doutriaux1 Why are you saying that the vectors should be curved? In the code, one of the vector components is 0 (you are doing u - u) so it is correct that the vectors are straight up. |
straight up means toward the north pole. In robinson, at the "north" the arrow should not be staright up be slightly tilted. does this makes sense? |
At the moment, there is no transform applied to the vector as far as I know. So I guess, you are expecting to to transform the points of the arrow using the same transform as for the points of the mesh. |
yes exactly |
Sounds good, I'll look into doing this. |
A problem with transforming the vectors is that the transformation may not equidistant. So the same size vector would look different sizes in different parts of the map. Is this something we want to have? |
@danlipsa i think so, but for the legend, let's use the length at the equator (or mid lat/lon of the plot) |
Points in the dataset are in lat lon, and vectors are in meters per second (I will assume that this will always be the case). This means that I will have to convert points from lat lon to UTM, compute the vector heads in UTM and than convert back to lat lon. Each point is potentially in a different UTM zone that means that I will do a different conversion for each point which may be slow. I think it makes sense to add vector projection as an option (if vectors are somehow abstract and not related to meters) - What should the default be? On? |
To me it seems to be incorrect not to project the vectors if the rest of the plot is in some projection, so I would think if it's an option, it should default to |
I agree with @scottwittenburg |
@danlipsa i get your point about units. But how do we do it in the "normal" case. I mean would the vector length change if the values are the same but units switch from "m/s" to "km/s" ? |
Let's do it for m/s and then it would be easy to look at the unit and make adjustments if we need to. The problem is that likely the vector size and direction will change differently depending where on where the vector is on the map. So the fact that we scale the vectors anyway to show them won't help. |
Looking great @danlipsa |
gives (all vector are straight up, they should be curved a bit)
and for

polar
projection we get 👍The text was updated successfully, but these errors were encountered: