Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For xvsy, markers are still being plotted when template.data.priority = 0 #214

Open
zshaheen opened this issue Jul 11, 2017 · 4 comments
Open
Assignees
Labels
Milestone

Comments

@zshaheen
Copy link

zshaheen commented Jul 11, 2017

This line isn't shown, but the markers are. Look at the black line in the image below.

screen shot 2017-07-11 at 2 51 21 pm

@doutriaux1
Copy link
Contributor

should probably read:
template.data.priority=0

@doutriaux1 doutriaux1 changed the title For xvsy, markers are still being plotted when gm.data.priority = 0 For xvsy, markers are still being plotted when template.data.priority = 0 Jul 11, 2017
@jypeter
Copy link
Member

jypeter commented Jul 12, 2017

This reminds me of something I have noticed this week in 2.8, but I did not have time to investigate, because I was helping a colleague with a script. Don't have time now, so just describing below what I noticed

I got the impression that even though the script explicitly set tpl.comment1.priority = 0, the comment1 was plotted when the script used x.plot(tpl, v, comment1="Some comment"). I thought that maybe this was not a bug, but a feature, like: if you are requesting comment1 in x.plot, override the tpl.comment1.priority

Don't have time to reproduce this, so if anybody has some feedback on this... Thanks!

@doutriaux1
Copy link
Contributor

@jypeter yes I think you're right if you pass a keyword we turn priority back on. But I think you're right it might not be desirable.

@doutriaux1 doutriaux1 self-assigned this Sep 5, 2017
@doutriaux1 doutriaux1 added this to the 3.0 milestone Sep 5, 2017
@doutriaux1 doutriaux1 added the bug label Sep 5, 2017
@zshaheen
Copy link
Author

@doutriaux1 This is still an issue. Here's how to recreate it:

  1. Follow steps 1-6 to create an env here: https://acme-climate.github.io/acme_diags/docs/html/install-config-run.html#environment-for-development
  2. Open the created html page and navigate to 'Zonal mean line plots' -> 'ANN'. This is the image
  3. To edit the vcs script that created this file, look at this file: https://github.com/ACME-Climate/acme_diags/blob/master/acme_diags/plot/vcs/zonal_mean_xy_plot.py . Specificlly, it's line 231 what causes the error, setting it to 0 makes it dotted.

@doutriaux1 doutriaux1 modified the milestones: 3.0, Next Release Mar 29, 2018
@doutriaux1 doutriaux1 modified the milestones: 8.1, 8.2 Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants