gettextcombined only gets textcombined object and not the texttable and textorientation separately

[zshaheen]

If we have a texttable and textorientation object (both named diff_min_label), the following does not work:

vcs_canvas.gettextcombined(Tt_name_src = 'diff_min_label', To_name_src = 'diff_min_label)

[zshaheen]

@doutriaux1 The solution you talked about, fixing gettextcombined() to return a textcombined from the texttable and textorientation might not work.

scriptrun() (or script_save(), forgot what it was called?) doesn't save a textcombined. Instead, it saves it as a texttable and textorientation. I think scriptrun() needs to modified to save a textcombined. Otherwise, you're still gonna have to create a textcombined in gettextcombined.

We can talk more in real life when you come back.

[doutriaux1]

@zshaheen yes but only once.

[zshaheen]

@doutriaux1 Oh, I get it. So I'm guessing that all of the get functions (getisofill()) also create objects as well, but only once. Makes sense.

[doutriaux1]

they return the object in the vcs.elements dictionary.

[doutriaux1]

@zshaheen I'm thinking of a way we could completely remove that vcs.elements while not breaking backward compatibility

[zshaheen]

@doutriaux1 Since you're using the dictionary as a cache, the objects will not be garbage collected b/c the # of references will always be at least one.

You should really use WeakKeyDictionary or WeakValueDictionary from the builtin weakref module. This will fix that problem, and hopefully some of the related memory problems.

[doutriaux1]

unless we define their del and have it run vcs.removeobject