Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scriptrun to take in file objects as arguments #169

Open
zshaheen opened this issue Apr 6, 2017 · 1 comment
Open

Allow scriptrun to take in file objects as arguments #169

zshaheen opened this issue Apr 6, 2017 · 1 comment
Assignees
Milestone

Comments

@zshaheen
Copy link

zshaheen commented Apr 6, 2017

So we can do something like this:

f = open('vcsscript.json', 'r')
cnvs.scriptrun(f)

instead of:

cnvs.scriptrun('vcsscript.json')

It's better for performance when creating a bunch of plots in a loop. This is trivial and requires only changing code around line 614 in vcs/utils.py. I'll hopefully do this soon.

@zshaheen zshaheen self-assigned this Apr 6, 2017
@doutriaux1
Copy link
Contributor

that's a great idea! Thanks!

@doutriaux1 doutriaux1 modified the milestone: 3.0 May 5, 2017
@doutriaux1 doutriaux1 modified the milestones: 3.0, post 3.0 Mar 29, 2018
@doutriaux1 doutriaux1 modified the milestones: 8.1, 8.2 Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants