-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a better way to attach a png to a map plot #162
Comments
@danlipsa this would be unreal! I wonder if the png hard code is optional? Could this also work with tif, jpeg etc inputs and overlays? |
@durack1 The png file format would not be required. It should work with any image known to VTK. |
@danlipsa great, I wonder what other stuff VTK can do could be a exposed through VCS.. this overlay stuff is very hard to do in other packages I'm familiar with |
@danlipsa I think that would be perfect! How long do you think it would take? |
@doutriaux1 A rough estimate: a few days to a week to add to one plot and maybe a few more days to extended to other plots. |
@durack1 I am nor sure what do you have in mind. |
ok, it's neat but I would vote to fix the test suite first on circleci. |
we can always put it in a nightly after the fact for @durack1 |
@doutriaux1 Yes, definitely, we'll do this after the release - And we cannot release unless we have a working test suit. |
@doutriaux1 @danlipsa |
@danlipsa, regarding other stuff to expose.. I'm naive as to what VTK can do, so maybe I need to browse the VTK example gallery and see what else is possible |
@durack1 @aashish24 @doutriaux1 Unfortunately, we are not as good as we should be in showcasing all visualizations we support. So, if you see something you like bring it up and we'll look into it. It is quite possible that we already support it. You can also take a look at |
@danlipsa thanks for the links.. I just took a peek and there was nothing there that jumped out at me.. Your suggestion of raising a query with an example (or sketch or similar) will be something I'll consider in the future.. |
@danlipsa with some considerable trial and error and a lot of help from @doutriaux1 I have managed to get the image that I was imagining: |
@durack1 @aashish24 @doutriaux1 Very nice! I think it would be great to get something like this without too much effort. |
@danlipsa @doutriaux1 @williams13 what would be really nice, is the ability to georeference the |
@durack1 Yes, definitely this is how we'll do it. I think there are images that are already geo-referenced. @aashish24 knows more about this. |
@danlipsa let me know when you get to look at this, we have a pub in the revision queue and I would really like to highlight this CDAT functionality if it's available at publication time.. |
@durack1 That would be very nice. I have vcs.js and upgrading vcs to OpenGl2 in my queue. Keep promoting this to @williams13 @doutriaux1 and @aashish24 and will get done. |
@danlipsa @doutriaux1 @williams13 @aashish24 I would certainly up-vote this feature, as it's not obvious to me that any other package is capable of generating these |
For a matplotlib example, with multiple options (blue marble, topographic relief etc) see https://matplotlib.org/basemap/users/geography.html @lee1043 this is the issue that I referenced in my email |
@durack1 yes but these are canned images by the developers, correct? We want full featured stuff, with any image. |
@doutriaux1 @durack1 Yes, it is canned image, but key thing of it is that the map image can be fitted to any type of map projection or region, automatically. |
The actual function is So there is considerable scope to do things alot better here! |
Currently, put_png is used to put a background image on the canvas. A template is used to scale the png image so that it fits the map plot, so the user has to fidget with the scaling option to get it to fit.
Instead, the scaling can be computed by vcs so that the png fits the map plot. It can also be extended to be used in map plots that use geographic projections.
Using the new API a user would only have to specify a png as an option to the plot. The image would be scaled so that it fits with the plot.
As @durack1 pointed out, this will have the further advantage that the png will be georeferenced so you can view the map centered at any latitude/longitude.
@doutriaux1 @aashish24 @durack1 What do you think about this enhancement?
The text was updated successfully, but these errors were encountered: