Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA to name of VTK conda package #153

Open
danlipsa opened this issue Mar 23, 2017 · 6 comments
Open

Add SHA to name of VTK conda package #153

danlipsa opened this issue Mar 23, 2017 · 6 comments
Milestone

Comments

@danlipsa
Copy link
Contributor

It is difficult to figure out what version of VTK a specific cdat installation uses. As sometimes we fix vcs bugs in VTK, it is difficult to say if the bug was fixed, or the fix does not work in certain conditions without VTK version. This simple addition will solve this problem.

@doutriaux1 @aashish24 What do you think?

@doutriaux1
Copy link
Contributor

I like the idea, does VTK have a mechanism for this? Otherwise I can add it to the conda verison after the date.

@danlipsa
Copy link
Contributor Author

ParaView superbuild has a mechanism to extract the SHA: See
https://gitlab.kitware.com/paraview/common-superbuild/blob/master/cmake/SuperbuildVersionMacros.cmake

@doutriaux1
Copy link
Contributor

I can gert the sha1 at build time that's not the issue, I was just wondering if VTK already does this and we can access it it at runtime. I'll add it to the conda version.

@danlipsa
Copy link
Contributor Author

@doutriaux1 No it does not as far as I know. You'll have to get this at build time.

@doutriaux1
Copy link
Contributor

@danlipsa ok so it's manual at the moment but did it for our latest nightlies

@aashish24
Copy link
Contributor

It is difficult to figure out what version of VTK a specific cdat installation uses. As sometimes we fix vcs bugs in VTK, it is difficult to say if the bug was fixed, or the fix does not work in certain conditions without VTK version. This simple addition will solve this problem.

@doutriaux1 @aashish24 What do you think?

+1

@danlipsa @doutriaux1 this is something has to be done by the package manager (conda in our case).

@doutriaux1 doutriaux1 modified the milestone: 3.0 May 5, 2017
@doutriaux1 doutriaux1 modified the milestones: 3.0, post 3.0 Mar 29, 2018
@doutriaux1 doutriaux1 modified the milestones: 8.1, 8.2 Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants