-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SHA to name of VTK conda package #153
Comments
I like the idea, does VTK have a mechanism for this? Otherwise I can add it to the conda verison after the date. |
ParaView superbuild has a mechanism to extract the SHA: See |
I can gert the sha1 at build time that's not the issue, I was just wondering if VTK already does this and we can access it it at runtime. I'll add it to the conda version. |
@doutriaux1 No it does not as far as I know. You'll have to get this at build time. |
@danlipsa ok so it's manual at the moment but did it for our latest nightlies |
+1 @danlipsa @doutriaux1 this is something has to be done by the package manager (conda in our case). |
It is difficult to figure out what version of VTK a specific cdat installation uses. As sometimes we fix vcs bugs in VTK, it is difficult to say if the bug was fixed, or the fix does not work in certain conditions without VTK version. This simple addition will solve this problem.
@doutriaux1 @aashish24 What do you think?
The text was updated successfully, but these errors were encountered: