Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (WIP) Implemented websocket to receive status about the job #444

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: (WIP) Implemented websocket to receive status about the job #444

wants to merge 1 commit into from

Conversation

SGI-CAPP-AT2
Copy link
Contributor

Description

Implemented Websockets for getting job status for tasks

Fixes #434

Checklist

  • Tests have been added or updated to cover the changes
  • Documentation has been updated to reflect the changes
  • Code follows the established coding style guidelines
  • All tests are passing

@SGI-CAPP-AT2
Copy link
Contributor Author

this should be WIP as #429 is yet to be merged

@SGI-CAPP-AT2 SGI-CAPP-AT2 changed the title feat: Implemented websocket to receive information about the job feat: (WIP) Implemented websocket to receive information about the job Jan 23, 2025
@SGI-CAPP-AT2 SGI-CAPP-AT2 changed the title feat: (WIP) Implemented websocket to receive information about the job feat: (WIP) Implemented websocket to receive status about the job Jan 23, 2025
@SGI-CAPP-AT2
Copy link
Contributor Author

SGI-CAPP-AT2 commented Jan 24, 2025 •
edited
Loading

Hey @its-me-abhishek ,
I've implemented websockets here but add-task request is not being sent after creating task in this branch but it works in main branch. Do you have any idea?
could you please check once what's mistake here?

while other operations such as mark as complete, delete is working but add-task is not working. Haven't made any changes related to it.

@its-me-abhishek
Copy link
Contributor

its-me-abhishek commented Jan 24, 2025 •
edited
Loading

Handlers need to be updated as CCSync now supports tags
Have opened a relevant issue for the app already
Maybe that could be related as you would be missing tags field in the payload

@SGI-CAPP-AT2
Copy link
Contributor Author

Handlers need to be updated as CCSync now supports tags
Have opened a relevant issue for the app already
Maybe that could be related as you would be missing tags field in the payload

Ok let me try that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update api_service to use WebSockets
2 participants
@SGI-CAPP-AT2 @its-me-abhishek