feat: Improve Pydantic configuration discrimination #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatEek
approved these changes
Jan 22, 2025
melisande-c
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Looks good, however if N2VDataConfig is removed in #365, then it will no longer be necessary to split at the configuration level?
Let's keep the discussion in a single place, I will create an issue. I will merge this for now. Easy enough to fall back to a single configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Did I mention I love Pydantic?
The discrimination between algorithm-specific configurations by Pydantic generates a lot of errors when failing (#356). This can be avoided using a
Discriminatorin theUnion.Changes Made
Related Issues
Breaking changes
No change.
Please ensure your PR meets the following requirements: