Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ModelCheckpoint parameters in convenience configuration functions #353

Open
jdeschamps opened this issue Jan 15, 2025 · 1 comment · May be fixed by #381
Open

Expose ModelCheckpoint parameters in convenience configuration functions #353

jdeschamps opened this issue Jan 15, 2025 · 1 comment · May be fixed by #381
Assignees
Labels
feature New feature or request good first issue Good for newcomers
Milestone

Comments

@jdeschamps
Copy link
Member

jdeschamps commented Jan 15, 2025

Problem

If users want to set the parameters of the checkpoointing, they need to modify the values directly into the Pydantic configuration:

from careamics.config import create_care_configuration

config = create_care_configuration(...)
config.training_config.checkpoint_callback.every_n_epochs = 5

We could instead allow a checkpoint_kwargs or better yet the ModelCheckpoint Pydantic model in the API for the convenience functions.

@jdeschamps jdeschamps added the feature New feature or request label Jan 15, 2025
@jdeschamps
Copy link
Member Author

We should be more explicit when passing it to CAREamist:

"training configuration (see TrainingConfig)."

@jdeschamps jdeschamps added this to the v0.1.0 milestone Jan 20, 2025
@jdeschamps jdeschamps added the good first issue Good for newcomers label Jan 20, 2025
@jdeschamps jdeschamps moved this to Backlog in v0.1.0 Jan 27, 2025
@jdeschamps jdeschamps moved this from Backlog to Todo in v0.1.0 Jan 27, 2025
@diyasrivas diyasrivas moved this from Todo to In Progress in v0.1.0 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
Status: In Progress
2 participants