Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review tests #289

Open
jdeschamps opened this issue Dec 6, 2024 · 2 comments
Open

Review tests #289

jdeschamps opened this issue Dec 6, 2024 · 2 comments
Labels
feature New feature or request
Milestone

Comments

@jdeschamps
Copy link
Member

jdeschamps commented Dec 6, 2024

Tests have gone a bit out of hand. We split the CI into three different types to accommodate the very lengthy LVAE tests, and to minimize the uploads to CodeCov.

We should review all tests to make them lighter, and offload the heavy testing to another platform (e.g. GitLab).

In addition:

  • generalize np.testing.assert_array_equal
  • review skipped tests
@jdeschamps jdeschamps added the feature New feature or request label Dec 6, 2024
@melisande-c
Copy link
Member

Maybe we want to split the tests so we have API tests separately to unit tests. Once we're at v1.0.0 we probably don't want to break the API between versions, so we could have tests that just look at function inputs/outputs and warn us if anything changes int a PR.

@jdeschamps
Copy link
Member Author

That's a good point. Given that we expect CAREamics to be consumed by third-party software, that would indeed make sense to make a specific CI for API and integration related tests, that would only run on linux for instance. That way we would consume less resource.

@jdeschamps jdeschamps added this to the v0.2.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants