Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Transform objects, should target be folded into new additional_arrays kwargs? #247

Open
melisande-c opened this issue Sep 13, 2024 · 0 comments
Open

In Transform objects, should target be folded into new additional_arrays kwargs? #247

melisande-c opened this issue Sep 13, 2024 · 0 comments
Labels
refactoring Streamline and improve source code

Comments

@melisande-c
Copy link
Member

melisande-c commented Sep 13, 2024 •
edited
Loading

For the sake of the LVAE submission, let's merge it as it. But we should open issues about the following:

  • One can just be discussed briefly in person: should target be folded in the additional arrays? Would require an additional PR.
  • One issue to discuss what to do with the N2VManipulate signature, and whether n2v loss can be modified to not require patch and mask, but just patch * mask.

Originally posted by @jdeschamps in #238 (comment)
@jdeschamps jdeschamps changed the title In Transform objects should target be folded into new additional_arrays kwargs In Transform objects, should target be folded into new additional_arrays kwargs? Sep 14, 2024
@jdeschamps jdeschamps added the refactoring Streamline and improve source code label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Streamline and improve source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdeschamps @melisande-c