Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return latest chapternumber with Manga #74

Open
C9Glax opened this issue Oct 27, 2023 · 3 comments · May be fixed by #167
Open

Return latest chapternumber with Manga #74

C9Glax opened this issue Oct 27, 2023 · 3 comments · May be fixed by #167
Assignees
Labels
enhancement New feature or request

Comments

@C9Glax
Copy link
Owner

C9Glax commented Oct 27, 2023

C9Glax/tranga-website#17 (comment)

@C9Glax C9Glax added the enhancement New feature or request label Oct 27, 2023
C9Glax added a commit that referenced this issue Oct 27, 2023
@db-2001
Copy link
Collaborator

db-2001 commented Oct 30, 2023

Would it be possible to implement this feature by scanning the highest chapter number in the filename, rather than unzipping each file? Just an idea, not sure how it works. I think the current untested version would just return the latest downloaded chapter on disk which isn't necessarily the highest downloaded chapter.

@C9Glax
Copy link
Owner Author

C9Glax commented Oct 30, 2023

latestChapterDownloaded = latestChapterDownloaded < chapterNumber ? chapterNumber : latestChapterDownloaded; makes sure it's the newest.

The problem with parsing filenames after the fact, is that the regex could mess up, should there be numbers in the title.
Unzipping and parsing from the ComicInfo.xml would give a 100% accurate result.

@db-2001
Copy link
Collaborator

db-2001 commented Nov 3, 2023

So if I understand correctly, this line of code is already in the API and should return the latestChapterDownloaded whenever a new chapter is downloaded, so Mangas added after the implementation should have this field be non-zero if they've had a chapter downloaded after then? Also it should work, in theory, when searching for a Manga? I ask because currently my version of the API (which isn't latest but does have these fields) is reporting all values as 0

@C9Glax C9Glax self-assigned this Feb 12, 2024
@C9Glax C9Glax linked a pull request Apr 19, 2024 that will close this issue
C9Glax added a commit that referenced this issue Apr 20, 2024
@C9Glax C9Glax linked a pull request Apr 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants