Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Enable compression of the downloaded images #236

Open
baal000 opened this issue Sep 4, 2024 · 6 comments · May be fixed by #167
Open

[Feature Request] Enable compression of the downloaded images #236

baal000 opened this issue Sep 4, 2024 · 6 comments · May be fixed by #167
Assignees
Labels
enhancement New feature or request

Comments

@baal000
Copy link

baal000 commented Sep 4, 2024

It might be good to add a toggle to compress the images before packing them into the cbz files as there might be significant decrease in necessary storage space.

Quick tests with jpegoptim reveal that it is possible to reduce the filesize of normal manga pages (black & white) to up to 1/3 of the original downloaded file without noticing a difference. In Color it was more noticable.

I added the testfiles as zips
Originals.zip Compressed.zip

@C9Glax C9Glax self-assigned this Sep 4, 2024
@C9Glax C9Glax added the enhancement New feature or request label Sep 4, 2024
@C9Glax
Copy link
Owner

C9Glax commented Sep 6, 2024

Probably after ServerV2 release

@C9Glax
Copy link
Owner

C9Glax commented Oct 27, 2024

Have been playing around for a bit with just simple jpeg compresssion and black/white Adaptive Threshold.
With just compression alone (comparison below), it is about 1/6th the space requirement (over more than just one image).

Raw Compressed

@C9Glax
Copy link
Owner

C9Glax commented Oct 27, 2024

BW sample:

@C9Glax
Copy link
Owner

C9Glax commented Oct 27, 2024

Should probably make the compression a value, instead of on/off

C9Glax added a commit that referenced this issue Oct 27, 2024
@baal000
Copy link
Author

baal000 commented Oct 28, 2024

I think that would be the best to let everyone decide for themselves how compressed it should be.
Ideally it would be configurable per Manga so you can change it. But I think that would push it.

Thanks for the great work

@C9Glax
Copy link
Owner

C9Glax commented Oct 28, 2024

It is configurable now between 1 and 100 JPEG Quality.
Configurable per Manga... I'll give the thought a spin, but probably not.

@C9Glax C9Glax linked a pull request Oct 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants