Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make circular domains work #69

Open
drieg opened this issue Dec 6, 2024 · 8 comments
Open

Make circular domains work #69

drieg opened this issue Dec 6, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@drieg
Copy link

drieg commented Dec 6, 2024

ICON External Parameter Request

Instructions

  1. Give this issue a meaningful title.
  2. Replace PASTE_YOUR_REQUEST_HERE with your request that you copied to clipboard:
{
  "extpar": {
      "igrid_type": 1,
      "iaot_type": 1,
      "ilu_type": 1,
      "ialb_type": 1,
      "isoil_type": 1,
      "itopo_type": 1,
      "lsgsl": false,
      "lfilter_oro": false,
      "lurban": false
  },
  "icontools": {
    "grid_level": 2,
    "grid_root": 7,
    "centre": 78,
    "subcentre": 255,
    "lspring_dynamics": true,
    "maxit": 1000,
    "beta_spring": 0.95,
    "icorotation": 36,
    "outfile": "ICON-Arctic",
    "domains": [
      {
        "region_type": 2,
        "center_lon": 0.0,
        "center_lat": 90.0,
        "hwidth_lon": 23.0,
        "hwidth_lat": 15.0,
        "lrotate": false
      }
    ]
  }
}
  1. Click on "Preview" to verify that the JSON format of your request is correctly formatted and displayed within a code block.
  2. Click on "Submit new issue".

Extpar Data Request will now process your data based on the request you provided here. Once the processing is successful, it will post a link in this issue.
The processed data will be available under that link for up to 7 days.

If you encounter any problems, please add the label Static Badge to the issue. Make sure you post all relevant information from the logfiles in the issue directly.

Status Labels

Labels reflect the current state of your request:

Static Badge - Your request is currently under processing. Please wait for further updates.

Static Badge - Your request has been successfully processed. You can download your data using the provided link.

Static Badge - Unfortunately, your request could not be processed. Please refer to the log files in the zip file at the download link for more details.

Static Badge - Your request was aborted. This might be due to a timeout. Please try again or contact support if the problem persists.

github-actions bot pushed a commit that referenced this issue Dec 6, 2024
@jenkins-apn
Copy link

Something went wrong. Please check the logfiles for more information.

@drieg
Copy link
Author

drieg commented Dec 6, 2024

@jonasjucker The logfile is empty. Could it be related to the circular region (region_type=2)?

@jonasjucker
Copy link
Contributor

gridgen failed:

 Simple icosahedral grid generator

 ---------------------------------

 05/2016 : F. Prill, DWD

 

 running with 32 thread(s).

 

 1 domain(s) specified.

 

 DOM 0:   grid R07B02 approx. resolution  180357.14m (created from scratch)

 DOM 1:   circular region (center lon/lat:   0.000,  0.000; radius:   0.000 deg)

 

  

 ----------------

 CREATE BASE GRID

 ----------------

  

 generate synthetic global base grid R07B02

  

 base grid R07B01: perform spring dynamics.

   it =    100; ekin =  0.21901E-02; max_ekin =  0.47758E-02

   it =    200; ekin =  0.71389E-04; max_ekin =  0.47758E-02

   it =    300; ekin =  0.13687E-04; max_ekin =  0.47758E-02

   it =    400; ekin =  0.52682E-05; max_ekin =  0.47758E-02

   iterated 413 times.

 base grid R07B02: perform spring dynamics.

   it =    100; ekin =  0.92745E-04; max_ekin =  0.53505E-03

   it =    200; ekin =  0.16217E-05; max_ekin =  0.53505E-03

   it =    300; ekin =  0.79329E-06; max_ekin =  0.53505E-03

   it =    400; ekin =  0.66779E-06; max_ekin =  0.53505E-03

   it =    500; ekin =  0.57407E-06; max_ekin =  0.53505E-03

   iterated 549 times.

 generate UUID for synthetic grid...  "2623e1a8-bf9b-7c46-53ae-1fa5fae92500"

 saving patch to NetCDF file "base_grid.nc"

   ncells = 15680; nedges = 23520; nverts = 7842

 write HTML plot "base_grid.html"

   *** no HTML output written: this is a global grid containing too many cells!

 

 -------

 DOM  1:   circular region (center lon/lat:   0.000,  0.000; radius:   0.000 deg)

 -------

 

 build refined patch...

   marked 0 cells for refinement.

  *** No further domains can be processed!

    domains which have been processed so far:  mo_icongridgen::gridgen_main: Circular dependency?

STOP 99

Could it be because the parameter is set toparent_id=0,1?

@drieg
Copy link
Author

drieg commented Dec 9, 2024

No, I think that the problem is that hwidth_lon and hwidth_lat are only available for rectangular domains (in contrast to what the namelist doc says). For circular domains, it needs radius instead. I guess this needs to be implemented first in src/gridgen_namelist.py before a circular domains can be chosen.

Edit: In the namelist doc it is fixed now https://gitlab.dkrz.de/dwd-sw/dwd_icon_tools/-/merge_requests/47

@jonasjucker
Copy link
Contributor

Ok good to know.
I will convert this into an issue to keep it in mind for later.

@jonasjucker jonasjucker added enhancement New feature or request and removed data request failed labels Dec 9, 2024
@jonasjucker jonasjucker changed the title R7B3 Make circular domains work Dec 9, 2024
@mjaehn
Copy link
Contributor

mjaehn commented Jan 30, 2025

@jonasjucker @drieg I think we discussed that we won't support circular domains. Or is that just for the initial (basic) version? If this should be implemented at a later stage, it can stay open.

@jonasjucker
Copy link
Contributor

Hm I think we won't support that. We can close it.

@drieg
Copy link
Author

drieg commented Jan 30, 2025

Circular domains are a quite nice feature and also rather low hanging fruit. Is the visualization in the frontend the problem?

If yes, maybe a compromise could be that it is not supported by the frontend, but the backend can deal with the corresponding entries, if inserted by hand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants