Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-hardcode chemical tracers work in prepare_data for ICON #37

Open
efmkoene opened this issue Oct 25, 2023 · 2 comments · Fixed by #59
Open

De-hardcode chemical tracers work in prepare_data for ICON #37

efmkoene opened this issue Oct 25, 2023 · 2 comments · Fixed by #59
Assignees
@efmkoene

Comments

@efmkoene
Copy link
Contributor

efmkoene commented Oct 25, 2023 •
edited
Loading

If I want to do a prepare_data job for ICON with, say, CO2 instead of CH4, I would have to change this code. It would be good if this was something I could specify in the job instead.

processing-chain/jobs/prepare_data.py

Line 445 in bfaaee4

ds_chem['TRCH4_chemtr'] = ds_chem['CH4_BG']

@mjaehn
Copy link
Contributor

mjaehn commented Nov 2, 2023

@efmkoene Thanks and good catch! Would you be willing to implement this and make a PR into https://github.com/C2SM/processing-chain/tree/v3.0-rc?

@mjaehn
Copy link
Contributor

mjaehn commented Jan 29, 2024

This is now part of the prepare_art_oem.py job.

@efmkoene efmkoene mentioned this issue Feb 5, 2024
Merged
@mjaehn mjaehn linked a pull request Feb 6, 2024 that will close this issue
Chemical renaming #59
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efmkoene efmkoene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chemical renaming C2SM/processing-chain
2 participants
@efmkoene @mjaehn