From e039f9c47ae4c7948a5b8146a0a6aeff6e6eaa2c Mon Sep 17 00:00:00 2001 From: Edoardo Paone Date: Fri, 31 Jan 2025 16:49:39 +0100 Subject: [PATCH 1/2] Re-enable diffusion tests when orchestration is False --- .../diffusion/tests/diffusion_tests/test_diffusion.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/model/atmosphere/diffusion/tests/diffusion_tests/test_diffusion.py b/model/atmosphere/diffusion/tests/diffusion_tests/test_diffusion.py index 4ad5195f7..f5eac620e 100644 --- a/model/atmosphere/diffusion/tests/diffusion_tests/test_diffusion.py +++ b/model/atmosphere/diffusion/tests/diffusion_tests/test_diffusion.py @@ -420,8 +420,8 @@ def test_run_diffusion_single_step( backend, orchestration, ): - if not orchestration or not helpers.is_dace(backend): - pytest.skip("This test is only executed for orchestration on dace backends") + if orchestration and not helpers.is_dace(backend): + pytest.skip("Orchestration test requires a dace backend.") grid = get_grid_for_experiment(experiment, backend) cell_geometry = get_cell_geometry_for_experiment(experiment, backend) edge_geometry = get_edge_geometry_for_experiment(experiment, backend) @@ -665,8 +665,8 @@ def test_run_diffusion_initial_step( backend, orchestration, ): - if not orchestration or not helpers.is_dace(backend): - pytest.skip("This test is only executed for orchestration only on dace backends") + if orchestration and not helpers.is_dace(backend): + pytest.skip("Orchestration test requires a dace backend.") grid = get_grid_for_experiment(experiment, backend) cell_geometry = get_cell_geometry_for_experiment(experiment, backend) edge_geometry = get_edge_geometry_for_experiment(experiment, backend) From 9cfa9671dc1c444ceafff3f7930ca4b8b9a0382d Mon Sep 17 00:00:00 2001 From: Edoardo Paone Date: Fri, 31 Jan 2025 17:33:08 +0100 Subject: [PATCH 2/2] disable embedded backend on diffusion tests --- .../diffusion/tests/diffusion_tests/test_diffusion.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/model/atmosphere/diffusion/tests/diffusion_tests/test_diffusion.py b/model/atmosphere/diffusion/tests/diffusion_tests/test_diffusion.py index f5eac620e..384d6a778 100644 --- a/model/atmosphere/diffusion/tests/diffusion_tests/test_diffusion.py +++ b/model/atmosphere/diffusion/tests/diffusion_tests/test_diffusion.py @@ -422,6 +422,8 @@ def test_run_diffusion_single_step( ): if orchestration and not helpers.is_dace(backend): pytest.skip("Orchestration test requires a dace backend.") + if helpers.is_embedded(backend): + pytest.xfail("Embedded backend currently fails in remap function.") grid = get_grid_for_experiment(experiment, backend) cell_geometry = get_cell_geometry_for_experiment(experiment, backend) edge_geometry = get_edge_geometry_for_experiment(experiment, backend) @@ -667,6 +669,8 @@ def test_run_diffusion_initial_step( ): if orchestration and not helpers.is_dace(backend): pytest.skip("Orchestration test requires a dace backend.") + if helpers.is_embedded(backend): + pytest.xfail("Embedded backend currently fails in remap function.") grid = get_grid_for_experiment(experiment, backend) cell_geometry = get_cell_geometry_for_experiment(experiment, backend) edge_geometry = get_edge_geometry_for_experiment(experiment, backend)