Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code #3

Open
mml1 opened this issue Feb 11, 2018 · 0 comments
Open

Reformat code #3

mml1 opened this issue Feb 11, 2018 · 0 comments

Comments

@mml1
Copy link

mml1 commented Feb 11, 2018

(Subtlety) Good start. You used ids properly and used it to change the background for the headings. You also did a great job with keeping blocks of code that belong together similarly formatted. However, I would suggest you wrap the similar chunks of code together in a div.

Instead of writing your code like this:

<div id="brushes">
    <h2> Brushes </h2>
  </div>
     <img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/hacksaw.jpeg" />
    <h3> Hacksaw Brushes </h3>
    <p> Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to hold paint in large amounts. Available in different sizes. <span id="price">Starting at $3.00 / brush.</span></p>

Reformat it to look like this:

<div class ="item">
    <h2  id="brushes"> Brushes </h2>
    <img src="https://s3.amazonaws.com/codecademy-content/courses/freelance-1/unit-2/hacksaw.jpeg" />
    <h3> Hacksaw Brushes </h3>
    <p> Made of the highest quality oak, Hacksaw brushes are known for their weight and ability to 
         hold paint in large amounts. Available in different sizes. <span id="price">Starting at $3.00 / 
         brush.</span>
    </p>
</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant