Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event planner #54

Open
Webatron11 opened this issue Jun 28, 2019 · 12 comments
Open

Event planner #54

Webatron11 opened this issue Jun 28, 2019 · 12 comments
Assignees
Labels
command issues related to bot commands enhancement New feature or request

Comments

@Webatron11
Copy link

Webatron11 commented Jun 28, 2019

My feature request is about

  • A new feature

Describe the solution you'd like
I would like the ability to convert times in one timezone to another timezone. For instance, you could run a command with the parameters of 10am GMT-5 to CET, and it would return 10am GMT-5 in CET time.

What needs to be done
see #54 (comment)

@Webatron11 Webatron11 added the enhancement New feature or request label Jun 28, 2019
@s0lst1ce s0lst1ce changed the title [REQUEST] Timezone converter Jun 28, 2019
@s0lst1ce s0lst1ce added this to the v2 milestone Jun 28, 2019
@s0lst1ce s0lst1ce pinned this issue Jun 28, 2019
@s0lst1ce
Copy link
Collaborator

Good idea. Will be implemented for v2

@s0lst1ce
Copy link
Collaborator

I've been thinking of two options. First we add some custom emojis for each "main" timezones. This could also be flag emojis... maybe. Flag emojis would get in the way of #43 though so I'd prefer not too. Anyways emoji reactions which would trigger a message with the converted timezone.
Or we could have a command that lets you write the time in your timezone and the bot returns an embed with a set of preselected timezones (which could be configured by an admin).
Which would you prefer ? Why ?

@morcup
Copy link

morcup commented Jun 28, 2019

I don't really know too much of how an embed works, could it be some sort of a dropdown menu thing? I like that idea.

@s0lst1ce
Copy link
Collaborator

s0lst1ce commented Jun 28, 2019

This is an embed embed

It's what the bot produces when you use the embed command. You can try it on discord if you want.

@s0lst1ce
Copy link
Collaborator

So I've been thinking at it again today. Although the idea did seem nice at first, developing the idea revealed its clear flaws. It would require a lot of clunky setups and lots of constraints for the user. I have thus thought of the use cases of a timezone converter. I've come to reach the conclusion that most cases requiring a timezone converter would be for planned events. Do you agree with this ?
If you do: I think that we could instead implement an "event" feature which would allow everyone (or select persons) to make events. This event would have description and all, probably formatted in an embed... Moreover it would have a functionality similar to the new reminder one (#61 ). It would give notifications to all users having applied to it an hour, a minutes, etc... before the event. This would be much more feasible and practical. Would it suit your needs ? If not do you have alternatives ?

@morcup
Copy link

morcup commented Jul 18, 2019

That sounds pretty good to me. What you're describing seems much simpler, yet still accomplishes the same things.

@s0lst1ce s0lst1ce self-assigned this Jul 18, 2019
@s0lst1ce s0lst1ce changed the title Timezone converter Event planner Jul 19, 2019
@s0lst1ce
Copy link
Collaborator

s0lst1ce commented Jul 19, 2019

Considering the change of plan for this feature here's the new tasklist:

Then we could also add some miscellaneous such as editing events. Bringing it up with another command. Binding a command to the event (ie: send a message in #news, send an invite) for when its countdown ends. Do you think any of those is interesting? Any other feature you'd like?

@s0lst1ce s0lst1ce added the command issues related to bot commands label Nov 6, 2019
@s0lst1ce s0lst1ce modified the milestones: v2, v3 Nov 6, 2019
@s0lst1ce s0lst1ce removed this from the v3 milestone Feb 17, 2020
@s0lst1ce
Copy link
Collaborator

s0lst1ce commented Feb 21, 2020

The way I see it is that there will be a new event group which will contain the following commands:

  • new enter the event creator context
  • send [name] sends the latest (or name) event built by the author in the current channel
  • start <name> force starts the specified event
  • rm <name> deletes the specified event

We will have to determine whether removal of an event should alert the subscribed members or not.
When creating an event a number of fields will have to be specified:

  • start date when the event should begin
  • reminder how much in advance should the subscribed members should be reminded (default: 1h)
  • name the name of the event
  • description all information relate to the event
  • attributed channel this is optional and will create a new channel restricted to the subscribed members with the specified name
  • role whether to create a role for this event and how it should be called

If I have not mentioned the possibility to link some fields to existing resources it is because the event creation process should take place in a DM, not in a guild. Thus mentions are not possible and requiring the user to hand-feed IDs not viable. If this is noted as too big of a flaw I could revise the planned method.

@s0lst1ce
Copy link
Collaborator

s0lst1ce commented Feb 21, 2020

Based on this here are the additional tasks needing to be added:

  • Implement new command
  • Implement send command
  • Implement close command to close admissions
  • Implement rm command
  • Implement list command to track all events
  • Implement edit command to edit a non-declared event
  • Implement preview command to see the full embed without sending it nor entering edition context

@s0lst1ce
Copy link
Collaborator

s0lst1ce commented Mar 6, 2020

this is the associated python structure that is planned to be used:

{
    "time": int,
    "name": str,
    "reminder": int,
    "description": str,
    "channel": int,
    "guild": int,
    "role": Union[bool, int]
}

@s0lst1ce
Copy link
Collaborator

Maybe all events shouldn't be free. By this I mean that only select members should be allowed to join? Although per-member selection hardly seems doable we could limit to select roles? This would mean that associated role wouldn't be free anymore. However this may be over complicating things since the issuer of the event already choose in which channel to send the event.

@s0lst1ce
Copy link
Collaborator

s0lst1ce commented Apr 2, 2020

To prevent abuse I'm adding another clearance level: planner.

@s0lst1ce s0lst1ce mentioned this issue May 4, 2020
2 tasks
@s0lst1ce s0lst1ce linked a pull request May 6, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command issues related to bot commands enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants