Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to denomination buttons #805

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

kiocosta
Copy link
Contributor

@kiocosta kiocosta commented Jan 29, 2025

Add labels to denomination buttons as a way of increasing clarity on the meaning of each symbol.

Screenshots

Desktop / Tablet

image

Mobile

Aligned items on center to prevent elements from overlapping on small screens

image

Copy link

vercel bot commented Jan 29, 2025

@kiocosta is attempting to deploy a commit to the boltz Team on Vercel.

A member of the Team first needs to authorize it.

@kiocosta kiocosta marked this pull request as draft January 29, 2025 12:55
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Feb 1, 2025 6:52am
webapp-mainnet ✅ Ready (Inspect) Visit Preview Feb 1, 2025 6:52am

@kilrau
Copy link
Member

kilrau commented Jan 29, 2025

I like it. Other opinions?

Copy link
Member

@michael1011 michael1011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On desktop it makes sense. Not sure about mobile though

@kilrau
Copy link
Member

kilrau commented Jan 29, 2025

Hmm it should fit left-aligned even on an iPhone SE screen, could you test and fix that? @kiocosta
image

@kiocosta
Copy link
Contributor Author

@kilrau It does fit, but I noticed the sats icon may jump to another line depending on the value inserted, but I will try to come up with a solution other than aligning center

image

@kiocosta
Copy link
Contributor Author

kiocosta commented Jan 30, 2025

@kilrau @michael1011 what about this one?

Mobile

image
Placed the text on the left with "tabular" style for easier reading and to align with other inputs.

Or perhaps this one?
image

I think it might also make sense to align it with the page title

Desktop version remains the same from the opening of this PR.


Uh oh, I created a regression on the settings menu! Will rework this on the next push.

@kilrau
Copy link
Member

kilrau commented Jan 30, 2025

Honestly, it's too much like this. It's a subtle config you probably only change once.

Two approaches how to continue for mobile:

  1. Stick with symbol only to make things fit
  2. Move btc/sats to settings menu

I tend to prefer 1 as on mobile amounts are often typed by hand and the switch is actually important (when pasting the btc/sats switch triggers smartomagically depending on the pasted amount but pasting is more of a desktop thing)

@kiocosta kiocosta force-pushed the add-denomination-label branch from b080d48 to a5ed360 Compare February 1, 2025 05:48
@kiocosta kiocosta marked this pull request as ready for review February 1, 2025 05:48
@kiocosta
Copy link
Contributor Author

kiocosta commented Feb 1, 2025

Honestly, it's too much like this. It's a subtle config you probably only change once.

Two approaches how to continue for mobile:

  1. Stick with symbol only to make things fit
  2. Move btc/sats to settings menu

I tend to prefer 1 as on mobile amounts are often typed by hand and the switch is actually important (when pasting the btc/sats switch triggers smartomagically depending on the pasted amount but pasting is more of a desktop thing)

Got it! I have reverted the mobile version to the original toggle and kept the buttons with label for the desktop version.

@michael1011 michael1011 merged commit 99c6cea into BoltzExchange:main Feb 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants