-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels to denomination buttons #805
Add labels to denomination buttons #805
Conversation
@kiocosta is attempting to deploy a commit to the boltz Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I like it. Other opinions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On desktop it makes sense. Not sure about mobile though
Hmm it should fit left-aligned even on an iPhone SE screen, could you test and fix that? @kiocosta |
@kilrau It does fit, but I noticed the sats icon may jump to another line depending on the value inserted, but I will try to come up with a solution other than aligning center |
@kilrau @michael1011 what about this one? Mobile
I think it might also make sense to align it with the page title Desktop version remains the same from the opening of this PR. Uh oh, I created a regression on the settings menu! Will rework this on the next push. |
Honestly, it's too much like this. It's a subtle config you probably only change once. Two approaches how to continue for mobile:
I tend to prefer 1 as on mobile amounts are often typed by hand and the switch is actually important (when pasting the btc/sats switch triggers smartomagically depending on the pasted amount but pasting is more of a desktop thing) |
Add labels as a way of "teaching" the users what each denomination symbol means.
b080d48
to
a5ed360
Compare
Got it! I have reverted the mobile version to the original toggle and kept the buttons with label for the desktop version. |
Add labels to denomination buttons as a way of increasing clarity on the meaning of each symbol.
Screenshots
Desktop / Tablet
Mobile
Aligned items on center to prevent elements from overlapping on small screens