feat: automatic denom switcher #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kilrau
requested changes
Jan 3, 2024
There was a problem hiding this comment.
btc -> sats switch works as expected, nice! Second bullet point of #391 is missing though: allow entering floats and autoswitch to btc if a . is entered. It needs both diretions, we had support cases the same way where people couldn't enter 0.1 as shown in sideswap.
Still not working (doesn't let me enter |
|
And conflicts need to be resolved |
michael1011
reviewed
Jan 7, 2024
michael1011
force-pushed
the
feat-autodenom
branch
from
ffc729a to
7e27242
Compare
kilrau
requested changes
Jan 8, 2024
kilrau
requested changes
Jan 11, 2024
switches to sat denom of amount > x
michael1011
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switches to sat denom of amount > x
closes #391