Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: placeholders instead of 0 on init #394

Merged
merged 2 commits into from
Jan 4, 2024
Merged

feat: placeholders instead of 0 on init #394

merged 2 commits into from
Jan 4, 2024

Conversation

dni
Copy link
Contributor

@dni dni commented Dec 21, 2023

screenshot-1703186406

@vercel Vercel
Copy link

vercel bot commented Dec 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Jan 4, 2024 7:25pm
webapp-mainnet ✅ Ready (Inspect) Visit Preview Jan 4, 2024 7:25pm

@kilrau kilrau requested review from michael1011 and kilrau January 3, 2024 10:21
@dni dni force-pushed the feat-placeholders branch from 016ce02 to 8bd32a2 Compare January 3, 2024 11:20
@dni dni force-pushed the feat-placeholders branch from 8bd32a2 to da6b93e Compare January 3, 2024 20:34
kilrau
kilrau reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of testing - works as expected. Will give it another spin after conflicts are resolved and you consider it final @dni

@dni dni force-pushed the feat-placeholders branch from fb97482 to 1061951 Compare January 4, 2024 19:24
@dni dni requested a review from kilrau January 4, 2024 19:24
@michael1011 michael1011 merged commit 0c770c0 into main Jan 4, 2024
2 checks passed
@michael1011 michael1011 deleted the feat-placeholders branch January 4, 2024 20:11
@kilrau kilrau mentioned this pull request Jan 9, 2024
Closed
michael1011 added a commit that referenced this pull request Jan 25, 2024
@michael1011
Revert "feat: placeholders for amounts instead of 0 on load (#394)"
a9b02d6 
This reverts commit 0c770c0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael1011 michael1011 michael1011 approved these changes

@kilrau kilrau Awaiting requested review from kilrau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dni @michael1011 @kilrau