Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add qrscanner for addresses and invoices #323

Merged
merged 13 commits into from
Jan 3, 2024
Merged

feat: add qrscanner for addresses and invoices #323

merged 13 commits into from
Jan 3, 2024

Conversation

dni
Copy link
Contributor

@dni dni commented Nov 18, 2023

Closes #300

qrcode scanner :)

  • BREAKING: camera needs https to be working so i added mkcert plugin for vite, works great but from now on we need https://localhost:5173/

Copy link

vercel bot commented Nov 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
webapp ✅ Ready (Inspect) Visit Preview Jan 3, 2024 9:56am
webapp-mainnet ✅ Ready (Inspect) Visit Preview Jan 3, 2024 9:56am

@dni
Copy link
Contributor Author

dni commented Dec 20, 2023

Clicking the image to close the QR code scanner without actually scanning a QR code is unintuitive. Keep the behaviour but put an X icon in some corner

fixed

Copy link
Member

@kilrau kilrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this branch? Looks like this has an address validation bug

image

@kilrau kilrau self-requested a review January 3, 2024 10:42
@michael1011
Copy link
Member

Can you rebase this branch? Looks like this has an address validation bug

are you on the right network?

@michael1011 michael1011 merged commit 8e86081 into main Jan 3, 2024
2 checks passed
@michael1011 michael1011 deleted the qrscanner branch January 3, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Scan QR Code
3 participants