fixup for signals

skipLibCheck is needed for an error in `solid-start` which is used by the storage primitives
BoltzExchange · Jan 3, 2024 · 2fce733 · 2fce733
1 parent d36d760
commit 2fce733
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 17 deletions.
diff --git a/package.json b/package.json
@@ -13,7 +13,7 @@
         "testnet": "cp src/configs/config.testnet.ts src/config.ts; vite build; cp dist/index.html dist/404.html",
         "prettier": "prettier --write src tests",
         "prettier-check": "prettier --check src tests",
-        "tsc": "tsc",
+        "tsc": "tsc --skipLibCheck",
         "changelog": "git-cliff -o CHANGELOG.md"
     },
     "devDependencies": {

diff --git a/src/components/CreateButton.tsx b/src/components/CreateButton.tsx
@@ -52,10 +52,7 @@ export const CreateButton = () => {
     const [buttonClass, setButtonClass] = createSignal("btn");
 
     const validateButtonDisable = () => {
-        return (
-            !valid() &&
-            !(lnurl() !== "" && lnurl() !== false && sendAmountValid())
-        );
+        return !valid() && !(lnurl() !== "" && sendAmountValid());
     };
 
     createEffect(() => {
@@ -85,16 +82,11 @@ export const CreateButton = () => {
     });
 
     const create = async () => {
-        if (
-            sendAmountValid() &&
-            !reverse() &&
-            lnurl() !== "" &&
-            lnurl() !== false
-        ) {
+        if (sendAmountValid() && !reverse() && lnurl() !== "") {
             try {
                 const inv = await fetchLnurl(lnurl(), Number(receiveAmount()));
                 setInvoice(inv);
-                setLnurl(false);
+                setLnurl("");
             } catch (e) {
                 setNotificationType("error");
                 setNotification(e);

diff --git a/src/components/InvoiceInput.tsx b/src/components/InvoiceInput.tsx
@@ -33,17 +33,17 @@ const InvoiceInput = () => {
                 setLnurl(inputValue);
             } else {
                 const sats = validateInvoice(inputValue);
-                setReceiveAmount(sats);
+                setReceiveAmount(BigInt(sats));
                 setSendAmount(calculateSendAmount(sats));
                 setInvoice(inputValue);
-                setLnurl(false);
+                setLnurl("");
                 setInvoiceValid(true);
             }
             input.setCustomValidity("");
             input.classList.remove("invalid");
         } catch (e) {
             setInvoiceValid(false);
-            setLnurl(false);
+            setLnurl("");
             input.setCustomValidity(t(e.message));
             setButtonLabel({ key: e.message });
             input.classList.add("invalid");

diff --git a/tests/components/InvoiceInput.spec.tsx b/tests/components/InvoiceInput.spec.tsx
@@ -74,7 +74,7 @@ describe("InvoiceInput", () => {
         expect(setInvoice).toHaveBeenCalledTimes(1);
         expect(setInvoice).toHaveBeenCalledWith(invoice);
 
-        setReceiveAmount(receiveAmount() + 1);
+        setReceiveAmount(receiveAmount() + 1n);
 
         expect(setInvoice).toHaveBeenCalledTimes(2);
         expect(setInvoice).toHaveBeenCalledWith("");
@@ -102,7 +102,7 @@ describe("InvoiceInput", () => {
         expect(setLnurl).toHaveBeenCalledTimes(1);
         expect(setLnurl).toHaveBeenCalledWith(lnurl.toLowerCase());
 
-        setSendAmount(sendAmount() + 1);
+        setSendAmount(sendAmount() + 1n);
 
         expect(input.value).toEqual(lnurl);
     });