diff --git a/kgforge/core/archetypes/mapping.py b/kgforge/core/archetypes/mapping.py index f78a66cb..11aba9a0 100644 --- a/kgforge/core/archetypes/mapping.py +++ b/kgforge/core/archetypes/mapping.py @@ -50,11 +50,6 @@ def __repr__(self) -> str: def __str__(self): return self._normalize_rules(self.rules) - def __eq__(self, other: object) -> bool: - # FIXME To properly work the loading of rules should normalize them. DKE-184. - # return eq_class(self, other) - raise NotImplementedError - @classmethod def load(cls, source: str, mapping_type: MappingType = None): # source: Union[str, FilePath, URL]. diff --git a/kgforge/specializations/mappings/dictionaries.py b/kgforge/specializations/mappings/dictionaries.py index b08cff19..27e43881 100644 --- a/kgforge/specializations/mappings/dictionaries.py +++ b/kgforge/specializations/mappings/dictionaries.py @@ -18,10 +18,16 @@ from kgforge.core.archetypes.mapping import Mapping from kgforge.core.commons.attributes import sort_attrs +from kgforge.core.commons.execution import not_supported class DictionaryMapping(Mapping): + def __eq__(self, other: object) -> bool: + # FIXME To properly work the loading of rules should normalize them. DKE-184. + # return eq_class(self, other) + raise not_supported() + @staticmethod def _load_rules(mapping: str) -> OrderedDict: return hjson.loads(mapping) diff --git a/kgforge/specializations/stores/demo_store.py b/kgforge/specializations/stores/demo_store.py index e62f8522..692bf36c 100644 --- a/kgforge/specializations/stores/demo_store.py +++ b/kgforge/specializations/stores/demo_store.py @@ -37,13 +37,6 @@ class DemoStore(Store): """An example to show how to implement a Store and to demonstrate how it is used.""" - def __init__(self, endpoint: Optional[str] = None, bucket: Optional[str] = None, - token: Optional[str] = None, versioned_id_template: Optional[str] = None, - file_resource_mapping: Optional[str] = None, - model_context: Optional[Context] = None) -> None: - super().__init__(endpoint, bucket, token, versioned_id_template, file_resource_mapping, - model_context) - @property def mapping(self) -> Type[Mapping]: """Mapping class to load file_resource_mapping."""