From edf9ebef0613250e3c0ff99b964fb656a7fb3342 Mon Sep 17 00:00:00 2001 From: Aivaras Skripka Date: Mon, 29 Feb 2016 13:08:39 +0000 Subject: [PATCH 1/2] Sending string instead of an object to avoid bad request error. --- build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index d5a61179a..23152cef1 100644 --- a/build.gradle +++ b/build.gradle @@ -298,7 +298,7 @@ task githubRelease, dependsOn:[generateReleaseNotes, ':brjs-sdk:distZip', build] def releaseNoteFile = generateReleaseNotes.outputs.files.singleFile def releaseJson = getReleaseNoteJson(project,tagVersion) - Release release = githubApi.createReleaseForTag(tagVersion, releaseJson, releaseNoteFile.text) + Release release = githubApi.createReleaseForTag(tagVersion, JSON.stringify(releaseJson), releaseNoteFile.text) githubApi.uploadAssetForRelease(brjsZip, release) } } From 7c83e2597903ded49b204b0c73c40e5f41ca70c7 Mon Sep 17 00:00:00 2001 From: Aivaras Skripka Date: Mon, 29 Feb 2016 15:56:39 +0000 Subject: [PATCH 2/2] Fixing regex expression issue, which cause release build to fail --- build.gradle | 2 +- .../main/groovy/org/bladerunnerjs/github/GitHubAPIBridge.groovy | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build.gradle b/build.gradle index 23152cef1..d5a61179a 100644 --- a/build.gradle +++ b/build.gradle @@ -298,7 +298,7 @@ task githubRelease, dependsOn:[generateReleaseNotes, ':brjs-sdk:distZip', build] def releaseNoteFile = generateReleaseNotes.outputs.files.singleFile def releaseJson = getReleaseNoteJson(project,tagVersion) - Release release = githubApi.createReleaseForTag(tagVersion, JSON.stringify(releaseJson), releaseNoteFile.text) + Release release = githubApi.createReleaseForTag(tagVersion, releaseJson, releaseNoteFile.text) githubApi.uploadAssetForRelease(brjsZip, release) } } diff --git a/buildSrc/src/main/groovy/org/bladerunnerjs/github/GitHubAPIBridge.groovy b/buildSrc/src/main/groovy/org/bladerunnerjs/github/GitHubAPIBridge.groovy index b2acd4560..bdca71205 100644 --- a/buildSrc/src/main/groovy/org/bladerunnerjs/github/GitHubAPIBridge.groovy +++ b/buildSrc/src/main/groovy/org/bladerunnerjs/github/GitHubAPIBridge.groovy @@ -131,7 +131,7 @@ class GitHubAPIBridge void uploadAssetForRelease(File brjsZip, Release release) { logger.quiet "uploading file ${brjsZip.path} for release ${release.tagVersion}" - def uploadUrl = release.upload_url.replaceFirst(/{\?[\S]+}/,'') // remove the {abc,xyz} templates at the end of the URL, see https://developer.github.com/v3/#hypermedia + def uploadUrl = release.upload_url.replaceFirst("\\{\\?[\\S]+\\}",'') // remove the {abc,xyz} templates at the end of the URL, see https://developer.github.com/v3/#hypermedia def response = doRequest(uploadsPrefix, "post", uploadUrl, "name=${brjsZip.name}", "application/zip", brjsZip) logger.quiet "successfully added release asset, ${brjsZip.toString()}" }