From e127534266b5eb5ba46e78e084824dc6b8a3bc61 Mon Sep 17 00:00:00 2001
From: Yash Deshwal <yashdeshwal@bitgo.com>
Date: Tue, 28 Jan 2025 23:10:10 +0530
Subject: [PATCH] fix: minor fixes
TICKET: WIN-4296
---
.../src/abstractSubstrateCoin.ts | 10 +++++++++-
modules/sdk-coin-tao/src/tao.ts | 15 +--------------
2 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/modules/abstract-substrate/src/abstractSubstrateCoin.ts b/modules/abstract-substrate/src/abstractSubstrateCoin.ts
index bff9426553..aae6ed12a2 100644
--- a/modules/abstract-substrate/src/abstractSubstrateCoin.ts
+++ b/modules/abstract-substrate/src/abstractSubstrateCoin.ts
@@ -93,7 +93,15 @@ export class SubstrateCoin extends BaseCoin {
/** @inheritDoc **/
generateKeyPair(seed?: Buffer): SubstrateKeyPair {
- throw new Error('Method not implemented.');
+ const keyPair = seed ? utils.keyPairFromSeed(new Uint8Array(seed)) : new SubstrateKeyPair();
+ const keys = keyPair.getKeys();
+ if (!keys.prv) {
+ throw new Error('Missing prv in key generation.');
+ }
+ return {
+ pub: keys.pub,
+ prv: keys.prv,
+ };
}
/** @inheritDoc **/
diff --git a/modules/sdk-coin-tao/src/tao.ts b/modules/sdk-coin-tao/src/tao.ts
index 84f3415b39..c05c45b28a 100644
--- a/modules/sdk-coin-tao/src/tao.ts
+++ b/modules/sdk-coin-tao/src/tao.ts
@@ -10,9 +10,7 @@ import {
VerifyTransactionOptions,
} from '@bitgo/sdk-core';
import { BaseCoin as StaticsBaseCoin } from '@bitgo/statics';
-import { Interface, KeyPair, SubstrateCoin, Utils } from '@bitgo/abstract-substrate';
-
-const utils = Utils.default;
+import { Interface, KeyPair, SubstrateCoin } from '@bitgo/abstract-substrate';
export const DEFAULT_SCAN_FACTOR = 20; // default number of receive addresses to scan for funds
@@ -73,17 +71,6 @@ export class Tao extends SubstrateCoin {
return {};
}
- generateKeyPair(seed?: Buffer): KeyPair {
- const keyPair = seed ? utils.keyPairFromSeed(new Uint8Array(seed)) : new KeyPair();
- const keys = keyPair.getKeys();
- if (!keys.prv) {
- throw new Error('Missing prv in key generation.');
- }
- return {
- pub: keys.pub,
- prv: keys.prv,
- };
- }
verifySignTransactionParams(params: SignTransactionOptions): VerifiedTransactionParameters {
const prv = params.prv;