Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph construction is currently subject to the circle problem #13

Closed
TransGirlCodes opened this issue Jul 9, 2019 · 0 comments · Fixed by #16
Closed

Graph construction is currently subject to the circle problem #13

TransGirlCodes opened this issue Jul 9, 2019 · 0 comments · Fixed by #16
Assignees
Labels
bug Something isn't working

Comments

@TransGirlCodes
Copy link
Member

The method of initial graph construction from kmers that is currently used is much more efficient now.

However, it still suffers from the circle problem in that kmers that have themselves as a de-bruijn neighbour forwards and backwards are not included in the unititgs.

This is a fairly known and simple problem to solve.

But since it's very very rare in real data, right now the algorithm just warns you. But we should fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant