Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connect-sequences.md #2688

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

lorin
Copy link
Contributor

@lorin lorin commented Dec 30, 2024

What has Changed?

On the "REPL Jack-in and Connect Sequences > Settings for adding Custom Sequences" doc page, added the following valid values for projectType

  • babashka
  • nbb
  • basilisp
  • joyride
  • cljs-only

I assume these are valid based on the ProjectType enum

Fixes #2687

My Calva Documentation Only PR Checklist

I have:

  • Read Editing Documentation. Note: there is no "Editing Documentation section on this page.
  • Directed this pull request at the published branch.
  • [] Built the site locally (if the changes were more involved than simple typo fixes), and verified that the site is presented as expected. (this was just a one-line text change so I didn't try to build it)
  • Referenced the issue I am fixing/addressing in a commit message for the pull request (if there was is an issue for the documentation change)
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

Add missing project types
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for calva-docs ready!

Name Link
🔨 Latest commit d166faa
🔍 Latest deploy log https://app.netlify.com/sites/calva-docs/deploys/6772dccac603c80008428dd2
😎 Deploy Preview https://deploy-preview-2688--calva-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PEZ PEZ merged commit 8600ca0 into BetterThanTomorrow:published Jan 3, 2025
5 checks passed
@PEZ
Copy link
Collaborator

PEZ commented Jan 3, 2025

Sorry for the complete radio silence. Thanks for the help with updating the docs! 🙏

@lorin lorin deleted the update-docs branch January 12, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect sequence docs don't mention babashka as valid project type
2 participants