Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Option to remove stack trace from exception logging #7520

Open
scraymondjr opened this issue Jan 3, 2025 · 0 comments
Open

[Feature]: Option to remove stack trace from exception logging #7520

scraymondjr opened this issue Jan 3, 2025 · 0 comments
Labels
enhancement New feature or request mlops user request

Comments

@scraymondjr
Copy link

scraymondjr commented Jan 3, 2025

The Feature

There does not appear to be any option to remove stack traces from exceptions when they are logged. This causes the function arguments to be logged, which defeats the purpose of the message redaction option (turn_off_message_logging) since the message content is still logged via the exception stack trace.

I propose that the turn_off_message_logging option include disable stack trace logging with another option to force the stack trace to be enabled if so desired (always_include_stack_trace or something). This would help to ensure that incoming messages are never logged, while allowing an option for the stack trace to remain if so desired.

I have attached a screenshot of a message sent to Sentry that shows the stack trace with the complete incoming request arguments available, even though turn_off_message_logging is set to true.

Motivation, pitch

If using the turn_off_message_logging option, then it may be presumed that there is a desire to avoid logging any user provided values. There should be a means for ensuring that absolutely no user provided values are logged for privacy conscious applications.

Are you a ML Ops Team?

Yes

Twitter / LinkedIn details

No response

Sample Sentry exception with stack trace

Screenshot 2025-01-03 at 6 59 22 AM
@scraymondjr scraymondjr added the enhancement New feature or request label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mlops user request
Projects
None yet
Development

No branches or pull requests

1 participant