Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zooming is bad/broken #770

Open
coolcool1994 opened this issue Aug 2, 2020 · 4 comments
Open

Zooming is bad/broken #770

coolcool1994 opened this issue Aug 2, 2020 · 4 comments

Comments

@coolcool1994
Copy link

coolcool1994 commented Aug 2, 2020

When you try to zoom-in top right, for instance, it doesn't zoom in top right, it zooms in more in the middle, not precise at all. This library doesn't even achieve the simple pinch the zoom gesture and hence it is useless. I have no idea why this library has 17k stars, because it just doesn't work well. Google's photo library app doesn't have this defect. iOS zooming (Apple has done the work for us unlike Android) doesn't have this defect. When I implemented zooming for a View in Android, it didn't have that defect. I guess I will have to implement my own solution instead of using this library.

I think it should be the top priority of this repo to fix the zooming to work naturally just like Google's built in Photos app or iOS apps. When you zoom in top left, it should zoom in top left where you are zooming, not in the center.

@Dimezis
Copy link

Dimezis commented Sep 19, 2020

@coolcool1994 This is an open source library, not something that is made by Google.
And it's no one's "top priority" to do the stuff you want.
Have some respect for the effort of the contributors, they did everything for free.
Don't like it - make a pull request and improve it, or open source your own solution.
It would be more helpful than ranting here and insulting the maintainers.

@marquessbr
Copy link

marquessbr commented Sep 19, 2020

And @coolcool1994, about implementing your own library, feel free, but, reinforcing what friend @Dimezis said, you should show some respect for the work that was done here, and a sincere advice: the library, like as is, works well, so , nothing would cost for you to fork the project, implement the functionality you need, and, since you are already benefiting from an open source project, make a pull request to put these changes to the branch master of it and everyone would be happy.
thanks

@marquessbr
Copy link

and I’m sorry to say, but it’s always that, who does it, leaves it done, who doesn’t do it, go there and put the stick in the buddy who made it and left it ready.

@coolcool1994
Copy link
Author

coolcool1994 commented Sep 19, 2020

I mean it seems like Yelp app is using this library, because the Yelp app has the same flaws. How could Yelp people not contribute!?!? Surprising.

Google Photos library people should contribute honestly. I have my own solution (totally separate project) that doesn't work as smooth as Google Photos library but does work the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants