Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response from REST when there's an error is still 200 #3

Open
dotasek opened this issue Jun 13, 2017 · 0 comments
Open

Response from REST when there's an error is still 200 #3

dotasek opened this issue Jun 13, 2017 · 0 comments

Comments

@dotasek
Copy link
Contributor

dotasek commented Jun 13, 2017

Relevant to the feature/cyrest branch

To replicate, load galFiltered.cys and click some blank space in the Network Control Panel to make the current network null.

Execute POST /mcode/v1/analyze with the default arguments.

The object returned contains only a partial CIError object, and also returns a 200 code instead of an HTTP error code such as 404 (for missing resource, which a null network would be).

A similar output from the Diffusion returns response code 404 and contains this object:

{
  "data": {},
  "errors": [
    {
      "status": 404,
      "type": "urn:cytoscape:ci:diffusion-app:v1:diffuse_current_view:1",
      "message": "Could not find current Network",
      "link": "file:/Users/hodor/CytoscapeConfiguration/3/framework-cytoscape.log"
    }
  ]
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant