Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually use the linter lol #60

Open
slifty opened this issue Mar 22, 2019 · 3 comments
Open

Actually use the linter lol #60

slifty opened this issue Mar 22, 2019 · 3 comments

Comments

@slifty
Copy link
Member

slifty commented Mar 22, 2019 •
edited
Loading

We have this super great linter all set up on the project, and what do I do? Nothing. I do nothing with it.

At this point most of the files have linting errors, and cleaning the project warrants an issue in itself.

image

In addition to fixing the linting issues, we should consider baking in a hook that requires linting to pass before a commit can register.
slifty added a commit that referenced this issue Mar 22, 2019
@slifty
Tweak linting
f6c2938 
In an attempt to fix linting issues (which I gave up on temporarilily
and just converted into issue #60) I corrected the linting config so
that it properly works with JSX inside of js files, as well as ignoring
non js files (e.g. json).
@reefdog
Copy link

reefdog commented Mar 22, 2019

I have found that satisfying the linter at the stub level of the project is annoying and can lead to premature work. (Like, rewriting a stateless component as a pure function to satisfy the linter when you know it'll use state soon.) But that's probably a minor and early-stage annoyance; satisfying the linter becomes increasingly valuable as the project ages.

@reefdog
Copy link

reefdog commented Mar 22, 2019 •
edited
Loading

Also on this set of projects I've embraced VS Code for the first time, and while I still often feel like I'm typing with mittens compared to a proper text editor, the integrated linter has been spectacular for catching this stuff in real time. It never even occurred to me you might have to lint manually.

@slifty
Copy link
Member Author

slifty commented Mar 22, 2019

I use sublime and just haven't spent the 30 minutes to research and set up an IDE linter. I should do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reefdog @slifty