Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between modalities classified - paper vs code #66

Open
deepakri201 opened this issue Nov 18, 2024 · 1 comment
Open

Discrepancy between modalities classified - paper vs code #66

deepakri201 opened this issue Nov 18, 2024 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@deepakri201
Copy link

Hi,

Thank you for this great toolbox. I've been trying out your pre-trained model, and have noticed a possible discrepancy between the modalities classified.

In your paper, I see that there are 12 modalities classified:

B-Value Volumes, T2-weighted (T2w), T1-weighted (T1w), Apparent Diffusivity Coefficient (ADC), Field Map, Proton Density (PD), Fluid-Attenuated Inversion Recov- ery (FLAIR), functional MRI (fMRI), Fractional Anisotropy (FA), T2*-weighted (T2star), Short Tau Inversion Recovery(STIR), exponential ADC (eADC).

However, in your code https://github.com/BRAINSia/dcm-classifier/blob/main/src/dcm_classifier/image_type_inference.py I see the following from lines 33-44, which shows 10 modalities:

imagetype_to_integer_mapping = {
    "t1w": 0,
    "gret2star": 1,
    "t2w": 2,
    "flair": 3,
    "b0": 4,
    "tracew": 5,
    "adc": 6,
    "fa": 7,
    "eadc": 8,
    "dwig": 9,
}

Thank you,

Deepa

@mbrzus
Copy link
Collaborator

mbrzus commented Nov 18, 2024

Hi Deepa,

You correctly spotted the difference! Initially, we started with 12 classes but over time narrowed it down to 10 because:

  • We didn't have enough robust data for some of the original modalities.
  • It didn't match up with what we needed for our current projects.

We continue our development, so the list of supported modalities might evolve. In the near future, we don't have plans to expand the supported modalities, but if you need to adapt the model for other data, we've got a tutorial on how to retrain it.

Thanks for using our tool, and let us know if you have any other questions!

Best,
Michal

@mbrzus mbrzus added the wontfix This will not be worked on label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants