Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date_time issue: timestamps won't match and YSI time as the "representative" time #14

Open
akshoelace opened this issue May 13, 2022 · 3 comments
Labels
core relating to core functionality of pkg

Comments

@akshoelace
Copy link
Collaborator

No description provided.

@atn38
Copy link
Contributor

atn38 commented May 13, 2022

Hey Sasha @akshoelace, allow me to hijack your issue and make it about the larger problem of times not matching up:

In 2022 hopefully we will start collecting not just dates but also times at stations. When we go to collate, these times may not match up, and may not match the YSI timestamps. It's not possible to include all the timestamps, so we decided to just merge based on the dates, and @alinaCO2spera proposed we should still include the YSI time in a column that "represents" the overall time.

@atn38 atn38 changed the title Data Date_Time Issue: YSI values that don't exactly match with water samples for time collected date_time issue: timestamps that won't match and YSI time as the "representative" time May 13, 2022
@atn38 atn38 changed the title date_time issue: timestamps that won't match and YSI time as the "representative" time date_time issue: timestamps won't match and YSI time as the "representative" time May 13, 2022
@atn38 atn38 added the core relating to core functionality of pkg label May 23, 2022
@atn38
Copy link
Contributor

atn38 commented May 23, 2022

Another issue: sometimes there are two or more YSI measurements made in a day. I think we're just gonna have multiple rows for that same day, and all other measurements will be duplicated.

@twhiteaker
Copy link

Duplicating other measurements might be confusing to the end user? How would they know what is a replicate sample and what has been programmatically duplicated?

I suggest including the timestamp when assembling data. If samples on the same day have different times, this will result in a lot of null values in the table. Yes it's ugly, but, if the user wants to aggregate, then can do so however they want, such as by day, hour, week, month. Perhaps for convenience, the collation function could have a Boolean option to group by day, with replicates averaged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core relating to core functionality of pkg
Projects
None yet
Development

No branches or pull requests

3 participants