From da96454ee16ffc9c62462caa45d108ef7e7cde57 Mon Sep 17 00:00:00 2001 From: nicola-d-bbc Date: Fri, 30 Jul 2021 16:17:58 +0100 Subject: [PATCH 1/5] changed svg wrapper max width to be in line with datestamp --- packages/components/psammead-brand/src/index.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/components/psammead-brand/src/index.jsx b/packages/components/psammead-brand/src/index.jsx index 8bdfc1f00e..dcd57bc293 100644 --- a/packages/components/psammead-brand/src/index.jsx +++ b/packages/components/psammead-brand/src/index.jsx @@ -6,7 +6,6 @@ import { GEL_GROUP_0_SCREEN_WIDTH_MAX, GEL_GROUP_2_SCREEN_WIDTH_MIN, GEL_GROUP_3_SCREEN_WIDTH_MIN, - GEL_GROUP_5_SCREEN_WIDTH_MIN, } from '@bbc/gel-foundations/breakpoints'; import { GEL_SPACING_HLF, @@ -18,6 +17,7 @@ const SVG_TOP_OFFSET_BELOW_400PX = '0.625rem'; // 10px const SVG_BOTTOM_OFFSET_BELOW_400PX = '0.375rem'; // 6px const SVG_BOTTOM_OFFSET_ABOVE_400PX = '0.75rem'; // 12px const SVG_BOTTOM_OFFSET_ABOVE_600PX = '1.25rem'; // 20px +const SVG_WRAPPER_MAX_WIDTH_ABOVE_1280PX = '78rem'; const SCRIPT_LINK_OFFSET_BELOW_240PX = 52; const PADDING_AROUND_SVG_BELOW_400PX = 16; const PADDING_AROUND_SVG_ABOVE_400PX = 28; @@ -33,7 +33,7 @@ const SvgWrapper = styled.div` justify-content: space-between; align-items: center; flex-wrap: wrap; - max-width: ${GEL_GROUP_5_SCREEN_WIDTH_MIN}; + max-width: ${SVG_WRAPPER_MAX_WIDTH_ABOVE_1280PX}; margin: 0 auto; @media (max-width: ${GEL_GROUP_0_SCREEN_WIDTH_MAX}) { From 8043844765f1edfebcf3586632afa97b09e2a8fb Mon Sep 17 00:00:00 2001 From: nicola-d-bbc Date: Mon, 2 Aug 2021 13:17:09 +0100 Subject: [PATCH 2/5] updated snapshot test --- .../psammead-brand/src/__snapshots__/index.test.jsx.snap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap b/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap index 81a98e5343..4c28151476 100644 --- a/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap @@ -32,7 +32,7 @@ exports[`Brand should render correctly with link not provided 1`] = ` -webkit-flex-wrap: wrap; -ms-flex-wrap: wrap; flex-wrap: wrap; - max-width: 80rem; + max-width: 78rem; margin: 0 auto; } From aabb3dcc0e958114c0797e7d4ecdc7cf468f73c1 Mon Sep 17 00:00:00 2001 From: nicola-d-bbc Date: Mon, 2 Aug 2021 13:43:02 +0100 Subject: [PATCH 3/5] updated changelog and package.json --- packages/components/psammead-brand/CHANGELOG.md | 1 + packages/components/psammead-brand/package.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/components/psammead-brand/CHANGELOG.md b/packages/components/psammead-brand/CHANGELOG.md index dc833aa698..1914203347 100644 --- a/packages/components/psammead-brand/CHANGELOG.md +++ b/packages/components/psammead-brand/CHANGELOG.md @@ -3,6 +3,7 @@ | Version | Description | | ------- | ----------- | +| 7.3.3 | [PR#4530](https://github.com/bbc/psammead/pull/4530) SVG Wrapper component max-width updated | | 7.3.2 | [PR#4497](https://github.com/bbc/psammead/pull/4497) Bump psammead-styles | | 7.3.1 | [PR#4486](https://github.com/bbc/psammead/pull/4486) upgrade minor/patch dependencies | | 7.3.0 | [PR#4452](https://github.com/bbc/psammead/pull/4452) Add linkId prop | diff --git a/packages/components/psammead-brand/package.json b/packages/components/psammead-brand/package.json index b553e1231b..1abf25d7e3 100644 --- a/packages/components/psammead-brand/package.json +++ b/packages/components/psammead-brand/package.json @@ -1,6 +1,6 @@ { "name": "@bbc/psammead-brand", - "version": "7.3.2", + "version": "7.3.3", "main": "dist/index.js", "module": "esm/index.js", "sideEffects": false, From c9e202b14e6d9d0a6ec60bd7e681a5abb79bb8b9 Mon Sep 17 00:00:00 2001 From: nicola-d-bbc Date: Mon, 2 Aug 2021 13:43:50 +0100 Subject: [PATCH 4/5] updated changelog and package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 31bcb5f047..55978a4239 100644 --- a/package.json +++ b/package.json @@ -66,7 +66,7 @@ "@bbc/gel-foundations": "6.1.3", "@bbc/moment-timezone-include": "1.1.8", "@bbc/psammead-assets": "3.1.9", - "@bbc/psammead-brand": "7.3.2", + "@bbc/psammead-brand": "7.3.3", "@bbc/psammead-bulleted-list": "3.0.18", "@bbc/psammead-bulletin": "5.0.36", "@bbc/psammead-byline": "3.0.19", From 582216f5b960aa7be18a8dc06bbeb6dd93bfcc0e Mon Sep 17 00:00:00 2001 From: nicola-d-bbc Date: Mon, 2 Aug 2021 14:08:51 +0100 Subject: [PATCH 5/5] fix snapshot tests --- .../psammead-brand/src/__snapshots__/index.test.jsx.snap | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap b/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap index 4c28151476..8397c7f996 100644 --- a/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap +++ b/packages/components/psammead-brand/src/__snapshots__/index.test.jsx.snap @@ -169,7 +169,7 @@ exports[`Brand should render correctly with link provided 1`] = ` -webkit-flex-wrap: wrap; -ms-flex-wrap: wrap; flex-wrap: wrap; - max-width: 80rem; + max-width: 78rem; margin: 0 auto; } @@ -328,7 +328,7 @@ exports[`Brand should render correctly with no service Localised Name 1`] = ` -webkit-flex-wrap: wrap; -ms-flex-wrap: wrap; flex-wrap: wrap; - max-width: 80rem; + max-width: 78rem; margin: 0 auto; } @@ -460,7 +460,7 @@ exports[`Brand should render correctly with transparent borders 1`] = ` -webkit-flex-wrap: wrap; -ms-flex-wrap: wrap; flex-wrap: wrap; - max-width: 80rem; + max-width: 78rem; margin: 0 auto; }