Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Threading exception when using ExtraQueryParameters #5108

Closed
bgavrilMS opened this issue Jan 31, 2025 · 1 comment · Fixed by #5109
Closed

[Bug] Threading exception when using ExtraQueryParameters #5108

bgavrilMS opened this issue Jan 31, 2025 · 1 comment · Fixed by #5109
Assignees
Labels

Comments

@bgavrilMS
Copy link
Member

Library version used

4.66

.NET version

net8

Scenario

ConfidentialClient - service to service (AcquireTokenForClient), ConfidentialClient - web api (AcquireTokenOnBehalfOf), ConfidentialClient - web site (AcquireTokenByAuthCode)

Is this a new or an existing app?

The app is in production, and I have upgraded to a new version of MSAL

Issue description and reproduction steps

For details see AzureAD/microsoft-identity-web#3228

Note that Id.Web always sets extra QP when calling Downstream API.

It's very easy to repro in MSAL:

  1. Create a CCA
  2. Call AcquireTokenForClient from 5 threads in a loop

Relevant code snippets

Expected behavior

No response

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

No response

Solution and workarounds

No response

@bgavrilMS bgavrilMS added needs attention Delete label after triage untriaged Do not delete. Needed for Automation labels Jan 31, 2025
@bgavrilMS bgavrilMS added P1 bug and removed untriaged Do not delete. Needed for Automation needs attention Delete label after triage confidential-client labels Jan 31, 2025
@bgavrilMS
Copy link
Member Author

Marking as P1 as it repros quite easily with few threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant