Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Question/Feedback]: Resource Naming in terraform-azurerm-avm-template #113

Open
1 task done
JFolberth opened this issue May 9, 2024 · 2 comments
Open
1 task done
Assignees

Comments

@JFolberth
Copy link
Contributor

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Description

Not sure best way to accommodate but AVM checklist calls out the need to add "resourceType-" as a variable/local for Terraform. The example today validates the name being passed into the module to ensure all lower case and numbers...the "-" will break this. https://azure.github.io/Azure-Verified-Modules/specs/shared/#id-snfr25---category-composition---resource-naming

The easy fix is to add the "-" into the validation rule. However looking to see if we should also add a TODO in variables w/ the default value corresponding to the resource name and curious if this should be accommodated for in the default testing process.

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Note

This label was added as per ITA06.

@matt-FFFFFF
Copy link
Member

Hi @JFolberth can you point me to the code in the repo that needs to change?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs: Triage
Development

No branches or pull requests

2 participants