Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding max limits on the depth of inheritance of Models in the DTDL v3 Spec #179

Open
joebeernink opened this issue Jan 25, 2024 · 3 comments

Comments

@joebeernink
Copy link

Currently, the DTDL V3 Spec limits the maximum depth of inheritance to 10 levels. Would it be possible to expand this limit to 12 or more?

@jrdouceur
Copy link
Collaborator

Not in V3, I'm afraid, but we can consider this increase in a future DTDL version. Do you have a particular use case that can help us justify a depth of 12?

@rido-min
Copy link
Member

Thanks @joebeernink for submitting this issue,

As this request implies to rev the DTDL v3 spec, we'd like to understand your use case, and which DTDL compatible services will need to be updated.

Before accepting this proposal, we need to think about compatibility with current DTDL version, although this does not seem a breaking change imho.

@jrdouceur might have more insights.

@wroantree-willow
Copy link

This is one example that we had recently, that we had to flatten to fit into the 10 level limit:

dtmi:com:willowinc:Capability;1
dtmi:com:willowinc:Parameter;1
dtmi:com:willowinc:Setpoint;1
dtmi:com:willowinc:StateSetpoint;1
dtmi:com:willowinc:BinarySetpoint;1
dtmi:com:willowinc:AlarmSetpoint;1
dtmi:com:willowinc:TemperatureAlarmSetpoint;1
dtmi:com:willowinc:HighTemperatureAlarmSetpoint;1
dtmi:com:willowinc:HighWaterTemperatureAlarmSetpoint;1
dtmi:com:willowinc:HighEnteringWaterTemperatureAlarmSetpoint;1
dtmi:com:willowinc:HighCoilEnteringWaterTemperatureAlarmSetpoint;1
dtmi:com:willowinc:HighChilledWaterCoilEnteringWaterTemperatureAlarmSetpoint;1

We had to flatten about 60 models to fit into the 10 level limit. 12 levels would be good, but 15 levels would give us additional room for the future. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants