From 02e5f7b8810903e2f1973e071da2018c02e9770b Mon Sep 17 00:00:00 2001 From: Michael Steinberg Date: Tue, 11 Sep 2018 18:06:51 -0700 Subject: [PATCH 1/2] force tranparent background on action trigger --- lib/components/Alert/Alert.scss | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/lib/components/Alert/Alert.scss b/lib/components/Alert/Alert.scss index 1ade339..21b2317 100644 --- a/lib/components/Alert/Alert.scss +++ b/lib/components/Alert/Alert.scss @@ -5,8 +5,6 @@ $line-height-text: 5*$grid-size; $line-height-close: 4*$grid-size; -$icon-margin-top: 3px; - .alert-container { position: relative; display: flex; @@ -23,12 +21,12 @@ $icon-margin-top: 3px; .alert-icon { @include md-box(inline-block, relative); margin-left: 2*$grid-size; - margin-top: $icon-margin-top; + margin-right: 2*$grid-size; + margin-top: $grid-size; flex: 0 0 4*$grid-size; } .alert-text { - margin-left: 2*$grid-size; margin-top: 1.25*$grid-size; margin-right: 3*$grid-size; padding-bottom: 2*$grid-size; @@ -75,6 +73,12 @@ $icon-margin-top: 3px; background-color: themed('color-bg-alert-info-close-hover'); } } + + .close-button-container { + &:hover, &:focus { + background: transparent; + } + } } } @@ -91,6 +95,10 @@ $icon-margin-top: 3px; .close-button-container { color: themed('color-text-black'); + + &:hover, &:focus { + background: transparent; + } } } } @@ -112,6 +120,10 @@ $icon-margin-top: 3px; .close-button-container { color: themed('color-text-white'); + + &:hover, &:focus { + background: transparent; + } } } From d851c4d25f6a1390816bb4ee313a9f3a698adbf5 Mon Sep 17 00:00:00 2001 From: Michael Steinberg Date: Tue, 11 Sep 2018 18:08:19 -0700 Subject: [PATCH 2/2] version --- CHANGELOG.md | 4 ++++ package.json | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 640271e..d732496 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # CHANGELOG +## v4.0.5 +### Fixed +- hover background for alert close button was incorrect on all browsers except firefox + ## v4.0.4 ### Fixed - add padding to fix select dropdown component where selected text overlaps with the icon diff --git a/package.json b/package.json index bd9fe1e..1e4e1b2 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@microsoft/azure-iot-ux-fluent-controls", - "version": "4.0.4", + "version": "4.0.5", "description": "Azure IoT Fluent React Controls", "main": "./lib/index.js", "types": "./lib/index.d.ts",