You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue was found in this PR when correcting the format of maxpagesize parameter of the pageable operations from string to int.
From the code, the parameter maxpagesize isn't passed correctly to the delegate func:
Then the test failed, as the maxpagesize is missing in the query parameter:
After digging into the code, the problem is not caused by the delegate func, but the GeneratorPageableHelpers.CreatePageable, which doesn't have a pagesize parameter:
However, the PageableHelpers.PageableImplementation has a pagesize parameter:
So the fixing should take 2 steps:
Add a overloading function which exposes the pagesize parameter, and pass it to PageableHelpers.PageableImplementation.
Fix the CodeGen to support it.
The text was updated successfully, but these errors were encountered:
This issue was found in this PR when correcting the format of
maxpagesize
parameter of the pageable operations fromstring
toint
.From the code, the parameter
maxpagesize
isn't passed correctly to the delegate func:Then the test failed, as the maxpagesize is missing in the query parameter:
After digging into the code, the problem is not caused by the delegate func, but the
GeneratorPageableHelpers.CreatePageable
, which doesn't have apagesize
parameter:However, the
PageableHelpers.PageableImplementation
has apagesize
parameter:So the fixing should take 2 steps:
pagesize
parameter, and pass it toPageableHelpers.PageableImplementation
.The text was updated successfully, but these errors were encountered: