Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pagesize parameter is not taken effect during the pageable operation #44735

Closed
ArthurMa1978 opened this issue Jun 26, 2024 · 1 comment
Closed
Assignees
Labels
Azure.Core Mgmt This issue is related to a management-plane library.

Comments

@ArthurMa1978
Copy link
Member

This issue was found in this PR when correcting the format of maxpagesize parameter of the pageable operations from string to int.
From the code, the parameter maxpagesize isn't passed correctly to the delegate func:
image
Then the test failed, as the maxpagesize is missing in the query parameter:
image

After digging into the code, the problem is not caused by the delegate func, but the GeneratorPageableHelpers.CreatePageable, which doesn't have a pagesize parameter:
image
However, the PageableHelpers.PageableImplementation has a pagesize parameter:
image

So the fixing should take 2 steps:

  1. Add a overloading function which exposes the pagesize parameter, and pass it to PageableHelpers.PageableImplementation.
  2. Fix the CodeGen to support it.
@ArthurMa1978 ArthurMa1978 added Mgmt This issue is related to a management-plane library. ARM - Core labels Jun 26, 2024
@welovej welovej closed this as completed Dec 30, 2024
@welovej
Copy link
Member

welovej commented Dec 31, 2024

regen PR: #47690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

No branches or pull requests

3 participants