Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for az network application-gateway waf-policy Bot 1.1 ruleset #29158

Closed
Shawnli222 opened this issue Jun 12, 2024 · 4 comments · Fixed by #30156
Closed

Add support for az network application-gateway waf-policy Bot 1.1 ruleset #29158

Shawnli222 opened this issue Jun 12, 2024 · 4 comments · Fixed by #30156
Assignees
@necusjz
Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team feature-request Network az network vnet/lb/nic/dns/etc...
Milestone
Backlog

Comments

@Shawnli222
Copy link

Describe the bug

Add support for az network application-gateway waf-policy Bot 1.1 ruleset

similar to this PR: #26888

Related command

az network application-gateway waf-policy managed-rule rule-set update --policy-name <> --resource-group <> --type 'Microsoft_BotManagerRuleSet' --version '1.1'

az network application-gateway waf-policy managed-rule rule-set add --policy-name <> --resource-group <> --type 'Microsoft_BotManagerRuleSet' --version '1.1'

Errors

Add 1.1 as an allowed input

Issue script & Debug output

Add 1.1 as an allowed input

Expected behavior

Add 1.1 as an allowed input

Environment Summary

na

Additional context

No response
@Shawnli222 Shawnli222 added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Jun 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Network az network vnet/lb/nic/dns/etc... label Jun 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 12, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 12, 2024

Thank you for opening this issue, we will look into it.

@yonzhan yonzhan removed the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Jun 13, 2024
@yonzhan yonzhan added this to the Backlog milestone Jun 13, 2024
@Shawnli222
Copy link
Author

Shawnli222 commented Aug 26, 2024 •
edited
Loading

Hi @yonzhan , want to check on the progess of this, this is requirement for our GA

@yonzhan yonzhan added feature-request and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 26, 2024
@Shawnli222
Copy link
Author

Hi @yonzhan just checking on the progress here, we need to test it soon in cli

@cxznmhdcxz
Copy link
Member

Hi @Shawnli222 , added 1.1 as allowed value but got this error when testing:

ApplicationGatewayFirewallUnknownRuleSetVersion
RuleSetVersion '1.1' is unsupported for specified RuleSetType 'Microsoft_BotManagerRuleSet' for Application Gateway Firewall

@cxznmhdcxz cxznmhdcxz mentioned this issue Oct 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@necusjz necusjz

Labels
Auto-Assign Auto assign by bot Azure CLI Team The command of the issue is owned by Azure CLI team feature-request Network az network vnet/lb/nic/dns/etc...
Projects
None yet
Milestone
Backlog
4 participants
@necusjz @cxznmhdcxz @yonzhan @Shawnli222