-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Define a culture to use when sorting objects #3722
Comments
Can be done multiple ways... |
Alternative 1: Be sure to always include the following when Sort-Object (...) -Culture 'en-US' |
Alternative 2 $PSDefaultParameterValues = @{
'Sort-Object:Culture'='en-US'
} |
Hey @MariusStorhaug, good call. I haven't seen this issue in quite some time actually. However, if it still exists (and from what you said I take it that's the case), I agree that we should do something about it. That said, I guess Alternative 2 seems to be the safer option - though I have to admit I haven't seen such an implementation anywhere yet. |
## Description - Added `-Culture 'en-US'` to all `Sort-Object` operations to mitigate issues some contributors with a different configured culture have - Re-ran the generation for all files (no changes) Related to Azure/ResourceModules#3722, but needs to be fixed there seperately ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [x] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation --------- Co-authored-by: Erika Gressi <[email protected]>
…1976) ## Description - Added `-Culture 'en-US'` to all `Sort-Object` operations to mitigate issues some contributors with a different configured culture have - Re-ran the generation for all files (no changes) Related to Azure/ResourceModules#3722, but needs to be fixed there seperately ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [x] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation --------- Co-authored-by: Erika Gressi <[email protected]>
Description
Add
-Culture 'en-US'
to allSort-Object
calls, so that sorting does not depend on the environment and culture of the one running the readme gen scripts.From #3665
Seems this pipeline recently failed due to sorting issues.
The text was updated successfully, but these errors were encountered: