Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Githubwebhook #10416

Closed
wants to merge 53 commits into from
Closed

Githubwebhook #10416

wants to merge 53 commits into from

Conversation

gokulkate96
Copy link

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@gokulkate96 gokulkate96 requested review from a team as code owners April 30, 2024 14:18
@@ -0,0 +1,53 @@
ColumnName,ColumnOrdinal,DataType,ColumnType
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this upto date?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

"installation","Success","Create","Informational",
"team","Success","Create","Informational",
"organization","Success","Other","Informational",
"label","Success","Other","Informational"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does github webhook provide these 12 event_s or are there more? if more, we should configure all.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configured 25 with reference to Product document

@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
Please check above comment and act accordingly. Thanks

@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
Please act on above comments and also it has validation failures. Thanks

@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
Please respond. Thanks

@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
We are waiting for your reply. Thanks

@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
Please check open comments from @vakohl and act on them. Thanks

@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
Please check open comments and also failure validations. Thanks

@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
Please respond on above. Thanks

@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
We wanted to check on the status of PR #10416. PR is pending for more than 30 days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR. Thank you for your cooperation

@v-atulyadav
Copy link
Contributor

Since we have not received a response in the last 7 days, we are closing your PR #10416 per our standard operating procedures. If you still need support for this issue, you can re-open the PR at any time.
If you do re-open, we simply request that you ensure the PR has response to the last request. Thank you for your cooperation.

@vakohl vakohl reopened this Jul 10, 2024
@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
Please reply to open comments; PR is having problems with validation. please check. Thanks

@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
Please act on open comments and also check for failed validations. Thanks

@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
Please respond on above asks. Thanks

@v-atulyadav
Copy link
Contributor

Hi @gokulkate96,
Please resolve branch conflicts. Thanks

@v-atulyadav
Copy link
Contributor

We wanted to check on the status of PR #10416. PR is pending for more than 60 days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR. Thank you for your cooperation

@v-atulyadav
Copy link
Contributor

Since we have not received a response in the last 7 days, we are closing your PR #10416 per our standard operating procedures. If you still need support for this issue, you can re-open the PR at any time.

If you do re-open, we simply request that you ensure the PR has response to the last request. Thank you for your cooperation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants