Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move geneva action jmespath code to C# #862

Open
jim-minter opened this issue Jul 2, 2020 · 1 comment
Open

Move geneva action jmespath code to C# #862

jim-minter opened this issue Jul 2, 2020 · 1 comment
Labels
priority-low Low priority issue or pull request size-medium Size medium

Comments

@jim-minter
Copy link
Member

Since #859:

Note: by running jmespath on the server with paging we will break things like [8:12] (our paging default is 10 clusters per page). so instead of getting 8,9,10,11 we will get 8,9,18,19,...

We should move the jmespath code to the C# wrapper. This is actually probably a good thing because it removes functionality from the RP.
@jim-minter jim-minter added priority-low Low priority issue or pull request size-medium Size medium labels Jul 2, 2020
@jim-minter jim-minter mentioned this issue Jul 2, 2020
Merged
@asalkeld asalkeld self-assigned this Jul 2, 2020
@asalkeld
Copy link
Contributor

https://msazure.visualstudio.com/One/_git/Compute-ARO-GenevaActions/pullrequest/3381555

@asalkeld asalkeld removed their assignment Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-low Low priority issue or pull request size-medium Size medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asalkeld @jim-minter