Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lineHeight property handling #201

Closed
lcgiry opened this issue Jan 9, 2024 · 5 comments
Closed

lineHeight property handling #201

lcgiry opened this issue Jan 9, 2024 · 5 comments

Comments

@lcgiry
Copy link

lcgiry commented Jan 9, 2024

Hello,

First of all, thank you for your very helpful work.

I noticed that pdfmake offers a lineHeight style property. Are you planning to handle it as well by any chance?

Thanks

@Aymkdn
Copy link
Owner

Aymkdn commented Jan 9, 2024

Maybe. I need to investigate how I can convert the CSS values to a value that would render similar with PDFMake.

@Aymkdn
Copy link
Owner

Aymkdn commented Jan 9, 2024

I think I'll restrict it to a number (unitless) only. It seems to be the preferred way to do it based on MDN.

Then a line-height:normal will be ignored, but any other number will be just passed to lineHeight in PDFMake.

@Aymkdn
Copy link
Owner

Aymkdn commented Jan 9, 2024

Actually, I went through my code, and lineHeight is already supported :-)

@Aymkdn Aymkdn closed this as completed Jan 9, 2024
@lcgiry
Copy link
Author

lcgiry commented Jan 10, 2024

Oh great thanks.

I don't think I saw it in your npmjs documentation but never mind, I'll try it !

@Aymkdn
Copy link
Owner

Aymkdn commented Jan 10, 2024

Indeed, it was missing on the README page. I've just added it (but it will only be visible on the NPM page when I'll publish a new version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants