Goals first: Reset onboard store when entering the flow #97936

zaguiini · 2025-01-03T13:44:07Z

Proposed Changes

Title. We're keeping the domain selection information as it is in case the user wants to create a new site with their previously selected domain (that they haven't bought.)

Why are these changes being made?

Because right now it's impossible to create two sites through /setup/onboarding.

Testing Instructions

Enter /setup/onboarding and create a site. Enter the flow again and create a second site. You should end up with two sites.

On trunk, the user is getting redirected to /sites after trying to create the second site.

Also, go through the flow with a paid domain and leave the cart while keeping the domain there. Enter /setup/onboarding and verify that the paid domain is preselected.

github-actions · 2025-01-03T13:44:21Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-129094

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-129094&env=jetpack

Automattic for Agencies live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-129094&env=a8c-for-agencies

matticbot · 2025-01-03T13:53:48Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~83 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-subscriptions         -126 B  (-0.0%)      -97 B  (-0.0%)
entry-main                  -126 B  (-0.0%)      -97 B  (-0.0%)
entry-login                 -126 B  (-0.0%)      -97 B  (-0.0%)
entry-domains-landing       -126 B  (-0.0%)      -97 B  (-0.0%)
entry-browsehappy           -126 B  (-0.1%)      -97 B  (-0.2%)
entry-stepper                -42 B  (-0.0%)      -83 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~545 bytes added 📈 [gzipped])

name                     parsed_size           gzip_size
onboarding-flow              +1018 B  (+4.8%)     +460 B  (+6.4%)
site-settings                  +84 B  (+0.0%)      +16 B  (+0.0%)
signup                         +84 B  (+0.0%)      +12 B  (+0.0%)
settings                       +84 B  (+0.0%)      +16 B  (+0.0%)
jetpack-connect                +84 B  (+0.0%)      +13 B  (+0.0%)
home                           +84 B  (+0.0%)      +18 B  (+0.0%)
checkout                       +84 B  (+0.0%)      +18 B  (+0.0%)
accept-invite                  +84 B  (+0.0%)      +13 B  (+0.0%)
link-in-bio-tld-flow           +12 B  (+0.0%)       +6 B  (+0.0%)
import-hosted-site-flow        +12 B  (+0.0%)       +1 B  (+0.0%)
copy-site-flow                 +12 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~101 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-domains                                                        +259 B  (+0.0%)      +43 B  (+0.0%)
async-load-purchase-modal-wrapper                                                       +84 B  (+0.0%)      +11 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...        +84 B  (+0.0%)      +11 B  (+0.0%)
async-load-calypso-lib-analytics-signup                                                 +84 B  (+0.6%)      +12 B  (+0.3%)
async-load-calypso-layout-masterbar-checkout                                            +84 B  (+0.1%)      +14 B  (+0.1%)
async-load-calypso-blocks-editor-checkout-modal                                         +84 B  (+0.0%)      +10 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

zaguiini · 2025-01-03T15:11:30Z

@paulopmt1 reported a problem with the approach (p1735915114483079-slack-C04H4NY6STW), so I piggybacked on @candy02058912's idea of clearing up the step persisted state.

This should be good to go now!

client/landing/stepper/declarative-flow/onboarding.ts

paulopmt1

Work as intended. Shared a full review here: p1736002952764819/1735915114.483079-slack-C04H4NY6STW

My main concern as a follow-up is to ensure the .wordpress.com domain suggestion always shows up as the first time we go through the flow.

Thanks for working on it @zaguiini and @candy02058912 !

p-jackson

After testing and talking in p1736137453158579/1735915114.483079-slack-C04H4NY6STW I think it's ok to move the reseting of the onboarding state to the front of the flow.

packages/onboarding/src/hooks/use-persisted-state.ts

candy02058912

Also, go through the flow with a paid domain and leave the cart while keeping the domain there. Enter /setup/onboarding and verify that the paid domain is preselected.

Domain is preseleted.
But the price isn't 0 with the "Free for the first year with annual paid plans." description. Also, the price doesn't match the regular price.

demo.mp4

Don't think that's a blocker for merging this PR as the amount in the checkout cart is still correct. (Free domain with an annual plan selected)

packages/onboarding/src/hooks/use-persisted-state.ts

zaguiini · 2025-01-06T19:45:58Z

That's fair @candy02058912 , here it is: 1742c4c

~~And also thank you for reporting that domain price problem. It was fixed with the same~~ EDIT: It's not fixed, I can still reproduce that.

The weird thing is if I go back to the design setup step and skip to domains again, it works 🤷🏻

Here's a fix that makes the free wpcom domain show up: 82c9bd8

cc @alshakero let me know if there's a better solution for this problem.

@p-jackson @vykes-mac, feel free to add the site setup onboard reset as a commit to this PR 👍🏻

…aded

...pper/declarative-flow/internals/steps-repository/unified-domains/use-is-managed-site-flow.ts

autumnfjeld · 2025-01-06T23:32:48Z

For reference, team testing discussed here: p1736205027317489/1736196927.663189-slack-C085HCWCEDN

p-jackson · 2025-01-07T02:59:58Z

client/landing/stepper/declarative-flow/internals/steps-repository/create-site/index.tsx

+		wasSignupCheckoutPageUnloaded() &&
+			signupDestinationCookieExists &&
+			isReEnteringFlow &&
+			getSignupCompleteSlug()


I've added this check because further on (in the createSite function), if isManageSiteFlow is true then we go ahead an use the signup complete slug, just assuming that it will be valid. So we shouldn't really go into that branch unless we also know the signup complete slug is valid.

This was causing an issue where if the user went back and made another site using the onboarding flow a 2nd time, isReEnteringFlow so it didn't think it had to create a site. But we don't have a site slug, we really do need to create a site.

…w name

matticbot · 2025-01-07T04:12:25Z

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

notifications
wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug goals-first/reset-store-at-start-of-flow on your sandbox.

candy02058912 · 2025-01-07T04:32:47Z

Shared testing creating two sites here: p1736224151854289/1736196927.663189-slack-C085HCWCEDN
There's also more discussions regarding this PR in that thread, so linking it here for context in the future.

Let's 🚢

…)" This reverts commit 9aae00e.

…)" (#98007) This reverts commit 9aae00e.

zaguiini mentioned this pull request Jan 3, 2025

Bug: Trying to create two sites in sequence in the new onboarding flow doesn't work #97887

Closed

zaguiini marked this pull request as ready for review January 3, 2025 13:45

zaguiini requested a review from a team January 3, 2025 13:45

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 3, 2025

zaguiini self-assigned this Jan 3, 2025

escapemanuele requested a review from a team January 3, 2025 15:52

vykes-mac reviewed Jan 3, 2025

View reviewed changes

client/landing/stepper/declarative-flow/onboarding.ts Outdated Show resolved Hide resolved

paulopmt1 approved these changes Jan 4, 2025

View reviewed changes

p-jackson approved these changes Jan 6, 2025

View reviewed changes

p-jackson reviewed Jan 6, 2025

View reviewed changes

packages/onboarding/src/hooks/use-persisted-state.ts Outdated Show resolved Hide resolved

p-jackson reviewed Jan 6, 2025

View reviewed changes

packages/onboarding/src/hooks/use-persisted-state.ts Outdated Show resolved Hide resolved

candy02058912 mentioned this pull request Jan 6, 2025

Onboarding: Clear store and persisted state when starting the flow #97920

Closed

8 tasks

candy02058912 approved these changes Jan 6, 2025

View reviewed changes

packages/onboarding/src/hooks/use-persisted-state.ts Outdated Show resolved Hide resolved

zaguiini added 3 commits January 6, 2025 16:14

Goals first: Reset onboard store when entering the flow

121a480

Clear all persisted state

9179ebd

Export the function directly instead of binding it to the hook

1742c4c

zaguiini force-pushed the goals-first/reset-store-at-start-of-flow branch from c5ee77d to 1742c4c Compare January 6, 2025 19:15

Clear signup complete site slug on flow enter

82c9bd8

only reset onboarding store if we are not in the goals first experiment.

70429c9

p-jackson mentioned this pull request Jan 6, 2025

Update/site setup no reset data in goals first #97972

Closed

8 tasks

Adds the multiDomainDefaultPlan product to the cart only after its lo…

37a86e0

…aded

zaguiini commented Jan 6, 2025

View reviewed changes

...pper/declarative-flow/internals/steps-repository/unified-domains/use-is-managed-site-flow.ts Outdated Show resolved Hide resolved

Can't be a "managed site flow" if there's no site slug to manage

40e9b2e

p-jackson reviewed Jan 7, 2025

View reviewed changes

Fix confusion between wordpress/data dispatching and redux dispatching

8b5aa47

Revert the change which made useIsManagedSiteFlowProps accept a flo…

cdf5f6c

…w name

p-jackson merged commit 9aae00e into trunk Jan 7, 2025
11 checks passed

p-jackson deleted the goals-first/reset-store-at-start-of-flow branch January 7, 2025 06:01

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 7, 2025

p-jackson added a commit that referenced this pull request Jan 7, 2025

Revert "Goals first: Reset onboard store when entering the flow (#97936…

238d736

…)" This reverts commit 9aae00e.

p-jackson mentioned this pull request Jan 7, 2025

Revert "Goals first: Reset onboard store when entering the flow" #98007

Merged

p-jackson added a commit that referenced this pull request Jan 7, 2025

Revert "Goals first: Reset onboard store when entering the flow (#97936…

a31ebf5

…)" (#98007) This reverts commit 9aae00e.

candy02058912 mentioned this pull request Jan 7, 2025

Goals first: Reset onboard store when entering the flow (v2) #98012

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Goals first: Reset onboard store when entering the flow #97936

Goals first: Reset onboard store when entering the flow #97936

zaguiini commented Jan 3, 2025 •

edited

Loading

github-actions bot commented Jan 3, 2025 •

edited by matticbot

Loading

matticbot commented Jan 3, 2025 •

edited

Loading

zaguiini commented Jan 3, 2025

paulopmt1 left a comment

p-jackson left a comment

candy02058912 left a comment •

edited

Loading

zaguiini commented Jan 6, 2025 •

edited

Loading

autumnfjeld commented Jan 6, 2025

p-jackson Jan 7, 2025

matticbot commented Jan 7, 2025

candy02058912 commented Jan 7, 2025 •

edited

Loading

Goals first: Reset onboard store when entering the flow #97936

Goals first: Reset onboard store when entering the flow #97936

Conversation

zaguiini commented Jan 3, 2025 • edited Loading

Proposed Changes

Why are these changes being made?

Testing Instructions

github-actions bot commented Jan 3, 2025 • edited by matticbot Loading

matticbot commented Jan 3, 2025 • edited Loading

zaguiini commented Jan 3, 2025

paulopmt1 left a comment

Choose a reason for hiding this comment

p-jackson left a comment

Choose a reason for hiding this comment

candy02058912 left a comment • edited Loading

Choose a reason for hiding this comment

zaguiini commented Jan 6, 2025 • edited Loading

autumnfjeld commented Jan 6, 2025

p-jackson Jan 7, 2025

Choose a reason for hiding this comment

matticbot commented Jan 7, 2025

candy02058912 commented Jan 7, 2025 • edited Loading

zaguiini commented Jan 3, 2025 •

edited

Loading

github-actions bot commented Jan 3, 2025 •

edited by matticbot

Loading

matticbot commented Jan 3, 2025 •

edited

Loading

candy02058912 left a comment •

edited

Loading

zaguiini commented Jan 6, 2025 •

edited

Loading

candy02058912 commented Jan 7, 2025 •

edited

Loading