Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Remove note from migration incentives card #90299

Merged
merged 1 commit into from
May 7, 2024

Conversation

nateweller
Copy link
Contributor

@nateweller nateweller commented May 3, 2024

Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/435

Proposed Changes

  • Removes the "Must have 3 or more sites to be eligible" note from the migration incentives card.

Testing Instructions

  • Load the /overview page and review the card.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Screenshots

Screenshot 2024-05-03 at 4 32 34 PM

@nateweller nateweller added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Size] XS Tiny sized issue A4A labels May 3, 2024
@nateweller nateweller requested a review from a team May 3, 2024 22:35
@nateweller nateweller self-assigned this May 3, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug remove/a4a/migration-incentive-note on your sandbox.

Copy link
Contributor

@andrii-lysenko andrii-lysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less is better 👍

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~37 bytes removed 📉 [gzipped])

name                        parsed_size           gzip_size
a8c-for-agencies-referrals       -113 B  (-0.1%)      -37 B  (-0.1%)
a8c-for-agencies-overview        -113 B  (-0.1%)      -37 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@nateweller nateweller merged commit 75bceaf into trunk May 7, 2024
15 checks passed
@nateweller nateweller deleted the remove/a4a/migration-incentive-note branch May 7, 2024 19:42
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4A [Size] XS Tiny sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants